Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year #25960

Closed
JmillsExpensify opened this issue Aug 25, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Aug 25, 2023

We recently removed the Send Money option from NewDot given that P2P wasn't slatted to become a near-term priority in the short-term. However, it's more important now that our core roadmap strategy has also changed.

As a result, we need to:

  • Add Send Money back to Global Create
  • Add Send Money back to 1:1 DMs
  • Continue not showing Send Money in other group contexts, such as policyExpenseChat or DMs with >2 members.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014191f72362bd850e
  • Upwork Job ID: 1699608593376403456
  • Last Price Increase: 2023-09-07
@JmillsExpensify JmillsExpensify added Weekly KSv2 NewFeature Something to build that is a new item. labels Aug 25, 2023
@JmillsExpensify JmillsExpensify self-assigned this Aug 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@neonbhai
Copy link
Contributor

neonbhai commented Aug 25, 2023

Hi! contributor here. I would love to contribute and help add this feature back to NewDot!

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@JmillsExpensify
Copy link
Author

I think we're going to keep this internal for now, but thanks! Adding the label for clarity.

@melvin-bot melvin-bot bot removed the Overdue label Sep 7, 2023
@JmillsExpensify JmillsExpensify added the Internal Requires API changes or must be handled by Expensify staff label Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014191f72362bd850e

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@JmillsExpensify
Copy link
Author

@coleaeason Do you want to take this on as part of the external commit?

@JmillsExpensify
Copy link
Author

If so, feel free to take it over.

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2023
@melvin-bot melvin-bot bot removed Overdue labels Sep 27, 2023
@techievivek techievivek added Daily KSv2 and removed Weekly KSv2 labels Sep 27, 2023
@techievivek
Copy link
Contributor

techievivek commented Sep 27, 2023

@JmillsExpensify QQ: Do we also need to bring back the docs for send money feature that were removed temporarily here #22226?

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@techievivek Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Oct 5, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Oct 13, 2023
@melvin-bot melvin-bot bot changed the title Re-introduce Send Money in anticipation of launch later this year [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year Oct 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@techievivek
Copy link
Contributor

Adding @eVoloshchak to the issue so we can pay them for the reviews.

@melvin-bot melvin-bot bot added Monthly KSv2 Daily KSv2 Overdue and removed Monthly KSv2 labels Oct 18, 2023
@eVoloshchak
Copy link
Contributor

Requested the $500 payment via NewDot

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@JmillsExpensify
Copy link
Author

Payment summary: $500 to @eVoloshchak for PR review.

@JmillsExpensify
Copy link
Author

$500 payment approved based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

7 participants