Bring back send money option for newDot #28321

techievivek · 2023-09-27T15:35:20Z

Details

Updated the code to bring back Send Money option on global create and DM chat reports. Also, tested the send money option with gold wallet that we recently launched.

Fixed Issues

$ #25960
PROPOSAL: N/A

Tests

Login to newDot and go to any DM chat report and confirm you can see the send money option.
Confirm you are able to see the Send money option in global create.
[Only for Internal testing] Follow the manual steps from this SO answer https://stackoverflowteams.com/c/expensify/a/10608/473 to setup a gold wallet and confirm you see an option to Pay with Expensify.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Login to newDot and go to any DM chat report and confirm you can see the send money option.
Confirm you are able to see the Send money option in global create.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

cloudflare-workers-and-pages · 2023-10-05T05:36:55Z

Deploying with Cloudflare Pages

Latest commit:	`1d21a0a`
Status:	✅ Deploy successful!
Preview URL:	https://71c11239.helpdot.pages.dev
Branch Preview URL:	https://techievivek-bring-back-send.helpdot.pages.dev

View logs

melvin-bot · 2023-10-05T09:27:02Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-10-05T11:27:35Z

@techievivek, just to make sure, is this supposed to just add a 'Send Money' option and all of the subsequent flow will be added later?
Currently, if you select 'Send Money' and proceed through the steps, the button on the last step still says 'Request'

Screen.Recording.2023-10-05.at.13.25.19.mov

techievivek · 2023-10-05T13:41:16Z

Currently, if you select 'Send Money' and proceed through the steps, the button on the last step still says 'Request'

Hmm, that's odd that is not expected, it should actually show the option to pay the amount. Let me verify this on my end.

techievivek · 2023-10-05T16:51:32Z

@eVoloshchak That should be fixed now, looks like we were only redirecting to request page navigateToRequestStep(CONST.IOU.MONEY_REQUEST_TYPE.REQUEST, option).

src/languages/en.ts

src/libs/Permissions.ts

joelbettner · 2023-10-05T17:36:12Z

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

@@ -126,7 +126,7 @@ function MoneyRequestParticipantsPage({iou, selectedTab, route}) {
                        ref={(el) => (optionsSelectorRef.current = el)}
                        participants={iou.participants}
                        onAddParticipants={IOU.setMoneyRequestParticipants}
-                        navigateToRequest={(option) => navigateToRequestStep(CONST.IOU.MONEY_REQUEST_TYPE.REQUEST, option)}
+                        navigateToRequest={(option) => navigateToRequestStep(iouType.current, option)}


Will this be different based on who is looking at the iou?

For instance, if I try to send you money will this be a MONEY_REQUEST_TYPE.REQUEST for you and a MONEY_REQUEST_TYPE.SEND for me?

This is part of the flow when a user taps on the send money button on either global create or on a DM. So it solely depends on the option you have selected in the beginning. So if a userA started the flow then it will always be a Send request for them and this page doesn't actually come into the picture for userB.

For instance, if I try to send you money will this be a MONEY_REQUEST_TYPE.REQUEST for you and a MONEY_REQUEST_TYPE.SEND for me?

I think we figure this out by the accountID and managerID, manager seems to be the payer and accountID is the payee.

eVoloshchak · 2023-10-06T11:33:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-06.at.13.13.24.mov

Mobile Web - Chrome

screen-20231006-132526.mp4

Mobile Web - Safari

Screen.Recording.2023-10-06.at.13.29.59.mov

Desktop

Screen.Recording.2023-10-06.at.13.50.21.mov

iOS

Screen.Recording.2023-10-06.at.13.28.13.mov

Android

screen-20231006-155727.mp4

eVoloshchak

One last thing, there is an error in console when you select a person to send the money to (i.e. http://localhost:8082/send/new/participants)

Also, this isn't related to this PR, but we might change IOUParticipantsPage to MoneyRequestParticipantsPage on this line

techievivek · 2023-10-06T12:59:41Z

@eVoloshchak, I am unable to reproduce the console error. What steps did you take to produce that error?

eVoloshchak · 2023-10-06T13:03:42Z

@techievivek

Press FAB -> Send Money
Enter an amount
Click 'Next'

Screen.Recording.2023-10-06.at.15.02.21.mov

techievivek · 2023-10-06T13:17:01Z

Screen.Recording.2023-10-06.at.6.35.59.PM.mov

Am I doing something wrong here? Anyway, I think selectedTab should be optional because we don't utilize the tab for the send money, right? We only use that for the request money?

techievivek · 2023-10-06T13:28:42Z

@eVoloshchak Made the selectedTab optional as we don't require it for the send money. It's only required in case of request money.

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

eVoloshchak

LGTM

melvin-bot · 2023-10-06T14:01:20Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf · 2023-10-09T16:31:51Z

Oops conflicts

techievivek · 2023-10-09T17:05:29Z

Fixing the conflict so we can get this merged ASAP.

techievivek · 2023-10-09T17:15:52Z

@marcochavezf resolved the conflicts. Ready for a review.

marcochavezf · 2023-10-09T17:43:12Z

It can't be merged because the PR is still marked with changes requested cc @joelbettner

joelbettner

🥳

joelbettner · 2023-10-10T14:45:37Z

So excited for this!!

OSBotify · 2023-10-10T14:52:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

aimane-chnaif · 2023-10-10T17:53:29Z

Though not a regression from this PR, it would have been better to fix this position:

techievivek · 2023-10-11T04:10:02Z

@aimane-chnaif Interesting, when I was testing this it looked just fine to me. Maybe it could be a result of my subsequent commits.

OSBotify · 2023-10-11T05:08:47Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-12T04:50:15Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

amyevans · 2023-10-23T14:19:14Z

This PR resulted in #29318

bring back send moeny option

3e10618

techievivek self-assigned this Sep 27, 2023

techievivek added 3 commits September 27, 2023 23:42

get rid of jsdoc

7bf917b

Merge branch 'main' into techievivek_bring_back_send_Money

94bd1df

Merge branch 'main' into techievivek_bring_back_send_Money

e666941

techievivek marked this pull request as ready for review October 5, 2023 09:26

techievivek requested a review from a team as a code owner October 5, 2023 09:26

melvin-bot bot requested review from eVoloshchak and removed request for a team October 5, 2023 09:27

techievivek added 2 commits October 5, 2023 19:45

bring back send money text

3bd3571

fix getting the value from ref

2b6d5ed

joelbettner suggested changes Oct 5, 2023

View reviewed changes

techievivek added 2 commits October 6, 2023 00:21

fix translation

24bb89d

remove send money beta

5d9ac2c

techievivek requested a review from joelbettner October 6, 2023 03:37

eVoloshchak suggested changes Oct 6, 2023

View reviewed changes

update the displayname

72bbd02

techievivek requested a review from eVoloshchak October 6, 2023 13:03

make selectedTab optional:

72b9d2e

eVoloshchak reviewed Oct 6, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Outdated Show resolved Hide resolved

default to undefined

ff41050

techievivek requested a review from eVoloshchak October 6, 2023 13:48

eVoloshchak approved these changes Oct 6, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf October 6, 2023 14:01

marcochavezf previously approved these changes Oct 6, 2023

View reviewed changes

resolve conflicts

1d21a0a

techievivek dismissed marcochavezf’s stale review via 1d21a0a October 9, 2023 17:15

techievivek requested a review from marcochavezf October 9, 2023 17:15

marcochavezf approved these changes Oct 9, 2023

View reviewed changes

joelbettner approved these changes Oct 10, 2023

View reviewed changes

joelbettner merged commit ac8000f into main Oct 10, 2023
16 checks passed

joelbettner deleted the techievivek_bring_back_send_Money branch October 10, 2023 14:45

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

aimane-chnaif mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-31][$500] App displays 'Pay with expensify' popup on side and not over the button #29332

Closed

6 tasks

OSBotify mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

melvin-bot bot mentioned this pull request Oct 13, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Re-introduce Send Money in anticipation of launch later this year #25960

Closed

amyevans mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-23][$500] Send money - Extra two digits are added before the decimal point when money is sent offline #29318

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring back send money option for newDot #28321

Bring back send money option for newDot #28321

techievivek commented Sep 27, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 5, 2023 •

edited

Loading

melvin-bot bot commented Oct 5, 2023

eVoloshchak commented Oct 5, 2023

techievivek commented Oct 5, 2023

techievivek commented Oct 5, 2023 •

edited

Loading

joelbettner Oct 5, 2023

techievivek Oct 5, 2023

eVoloshchak commented Oct 6, 2023 •

edited

Loading

eVoloshchak left a comment

techievivek commented Oct 6, 2023

eVoloshchak commented Oct 6, 2023

techievivek commented Oct 6, 2023 •

edited

Loading

techievivek commented Oct 6, 2023

eVoloshchak left a comment

melvin-bot bot commented Oct 6, 2023

marcochavezf commented Oct 9, 2023

techievivek commented Oct 9, 2023

techievivek commented Oct 9, 2023

marcochavezf commented Oct 9, 2023

joelbettner left a comment

joelbettner commented Oct 10, 2023

OSBotify commented Oct 10, 2023

aimane-chnaif commented Oct 10, 2023

techievivek commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 12, 2023

amyevans commented Oct 23, 2023

Bring back send money option for newDot #28321

Bring back send money option for newDot #28321

Conversation

techievivek commented Sep 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 5, 2023 • edited Loading

Deploying with Cloudflare Pages

melvin-bot bot commented Oct 5, 2023

eVoloshchak commented Oct 5, 2023

techievivek commented Oct 5, 2023

techievivek commented Oct 5, 2023 • edited Loading

joelbettner Oct 5, 2023

Choose a reason for hiding this comment

techievivek Oct 5, 2023

Choose a reason for hiding this comment

eVoloshchak commented Oct 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

techievivek commented Oct 6, 2023

eVoloshchak commented Oct 6, 2023

techievivek commented Oct 6, 2023 • edited Loading

techievivek commented Oct 6, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 6, 2023

marcochavezf commented Oct 9, 2023

techievivek commented Oct 9, 2023

techievivek commented Oct 9, 2023

marcochavezf commented Oct 9, 2023

joelbettner left a comment

Choose a reason for hiding this comment

joelbettner commented Oct 10, 2023

OSBotify commented Oct 10, 2023

aimane-chnaif commented Oct 10, 2023

techievivek commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 12, 2023

amyevans commented Oct 23, 2023

techievivek commented Sep 27, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 5, 2023 •

edited

Loading

techievivek commented Oct 5, 2023 •

edited

Loading

eVoloshchak commented Oct 6, 2023 •

edited

Loading

techievivek commented Oct 6, 2023 •

edited

Loading