[HOLD for payment 2023-09-20] [$500] IOU - "/edit/subdirectory" from the amount page shows blank RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Open any request money room ( request one if there is no previous requests )
3. Open the Money request room
4. Open the details room of one request
5. Click on the amount to open the amount page
6. Now go and modify the url to end with "/edit/subdirectory", you can add any subdirectory you want except "amount"

Expected Result:

1. Redirect the user to the previous room. ( this is what happened when you try to open the "/edit/amount" from a deleted request room )
2. Display the "Hmm... it's not here" page

Actual Result:

A blank RHP is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.57-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.18-08-23.02_51_16.1.webm

Recording.2992.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Ahmed-Abdella

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692317384241769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01480fed14ee7c9bd7
• Upwork Job ID: 1696159404102758400
• Last Price Increase: 2023-08-28
• Automatic offers:
• dukenv0307 | Contributor | 26400484
• Ahmed-Abdella | Reporter | 26400485

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"/edit/subdirectory" from the amount page shows blank RHP

What is the root cause of that problem?

We return null here if the fieldToEdit is invalid field

App/src/pages/EditRequestPage.js

Line 171 in 00efce4

return null;

What changes do you think we should make in order to solve the problem?

We should return not found page here

return <FullPageNotFoundView shouldShow/>;

App/src/pages/EditRequestPage.js

Line 171 in 00efce4

return null;

or we can update the useEffect here if the field is invalid

App/src/pages/EditRequestPage.js

Line 91 in 00efce4

Navigation.dismissModal();

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01480fed14ee7c9bd7

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Upwork job price has been updated to $500

[mountiny]

Making this $500 as its edge case normal user wont run into

[melvin-bot]

📣 @LuckyBoy1004! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[davewish]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"/edit/subdirectory" from the amount page shows blank RHP

What is the root cause of that problem?

when editField becomes invalid or does not exist EDIT_REQUEST_FIELD field , null is returned

App/src/pages/EditRequestPage.js

Line 171 in ed8f3e6

return null;

What changes do you think we should make in order to solve the problem?

When editField. is invalid , we should return
return <NotFoundPage/>;

What alternative solutions did you explore? (Optional)

We should return return <FullPageNotFoundView shouldShow/>;

[melvin-bot]

📣 @davewish! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[davewish]

Contributor details
Your Expensify account email: dvwish9214@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01e47e5f2122786310

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[maddylewis]

bumping @thesahindia - lmk if you have the bandwidth for this one. otherwise, i can reach out to another C+ to get the proposals reviewed. thanks!

[dukenv0307]

@maddylewis Can you take a look at @bondydaa 's comment here #26014 (comment). This issue should have the bonus.

[Ahmed-Abdella]

@maddylewis It is actually 250$ for reporting bonus? It is reported and assigned before changing the bonus rate and the offer sent on upwork is 250$? It was assigned with 500$ fixing offer just because it was an edge case.

[maddylewis]

paid

[melvin-bot]

@bondydaa, @maddylewis, @thesahindia, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[maddylewis]

@Ahmed-Abdella - sorry, im not following. why would you be paid $500 as a reporting bonus?

[Ahmed-Abdella]

@maddylewis this didn't happen it is just 250$

[Ahmed-Abdella]

@maddylewis Are we okay?
if you talk about this comment #26014 (comment).
I was talking about the FIXING bounty not reporting bonus. I believe there may be a misunderstanding, or perhaps my English skills are not adequate.

[maddylewis]

im still not following -- you are listed as the reporter of the bug on this issue. you are not assigned as the Contributor or the C+.

@bondydaa am i missing something?

[Ahmed-Abdella]

@maddylewis we are OK. I am just the reporter. You didn't miss anything. I was not talking about myself when I mentioned the fixing payment.

[Ahmed-Abdella]

Payments

• @thesahindia ($1000 via NewDot)
• @dukenv0307 ($1000 via Upwork)
• @Ahmed-Abdella ($250 via Upwork)

This payments checks before editing was 50 for reporting bonus at first I just wanted to clarify that it should be 250 in those checks. That is all I wanted to clarify with my comments nothing more. We are completely fine now. Sorry for the confusion.

[maddylewis]

@Ahmed-Abdella - okay i gotcha!

yep, after August 30, the reporting bonus is $50. But, bc you reported this on August 26, you qualified for the old reporting bonus amount ($250).

[maddylewis]

@thesahindia - will you run through this checklist when you have a chance? #26014 (comment)

[thesahindia]

It was an edge case so we just need to add a test case.

Steps -

1. Create a money request
2. Go to detail of the request
3. Click on amount to open edit page
4. Edit URL with invalid field edit
5. Verify that page not found appears

[thesahindia]

Payments

• @thesahindia ($1000 via NewDot)
• @dukenv0307 ($1000 via Upwork)
• @Ahmed-Abdella ($250 via Upwork)

@maddylewis, please update the payment summary to include the bonus so that it doesn't create any confusion.

[maddylewis]

@thesahindia - update which payment summary? and include what bonus?

[thesahindia]

I was talking about this comment. It says $1000 but it should be $1500 as per #26014 (comment). The comment needs to be updated so that it doesn't create any confusion when I request money on new dot.

[maddylewis]

oh oh you're talking about this comment where bondy clarified that this is actually eligible for the bonus - #26014 (comment)

got it 👍

[maddylewis]

@dukenv0307 - do i owe you $500 bonus?

[thesahindia]

Oh yeah that is correct! I got confused by the previous payment summary.

[maddylewis]

• @thesahindia ($750 via NewDot)
• @dukenv0307 ($750 via Upwork)
• @Ahmed-Abdella ($250 via Upwork)

[maddylewis]

ok sent @dukenv0307 $250 bonus ($750 total). closing!

[JmillsExpensify]

$750 payment approved for @thesahindia based on this comment.