[HOLD for payment 2023-10-09] [$500] Border appears for the User avatar on the Money request page header.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat and request Money ( make sure it works by avoiding the bugs around the IOU feature Now ) and Open it, you could Open any existing money request message
2. Notice the avatars on the money request header
3. May be you will need to zoom in to notice it clearly

Expected Result:

The avatar shouldn't have any border.

• Or to be more accurate, The border color for avatar should match the background color, to be invisible and style the both participants avatar like we want

Actual Result:

The user avatar has a border.

• The avatar border has a different shade of green, creating a border effect. The border appears because we should give it a boder color that matches the background color to be invisible and gave us the style we want for both participants avatars. Like the avatars in money request message in the main chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.22-08-23.04_37_03.webm

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692669808539929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013384dd572fef261e
• Upwork Job ID: 1699883091268702208
• Last Price Increase: 2023-09-07
• Automatic offers:
• bernhardoj | Contributor | 26665036
• Ahmed-Abdella | Reporter | 26665037

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

This looks like an intended behavior

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border appears for the second user avatar on the money request page header

What is the root cause of that problem?

We have AvatarWithDisplayName component in HeaderWithBackButton of MoneyReportHeader

We're setting the second avatar style here in the AvatarWithDisplayName component

App/src/components/AvatarWithDisplayName.js

Line 115 in c20c387

secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.highlightBG)]}

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to change highlightBG to appBG in AvatarWithDisplayName component

        <MultipleAvatars
            icons={icons}
            size={props.size}
            secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.appBG)]}
        />

This works fine

Note: We can add additional props for setting second avatar style in the AvatarWithDisplayName component

Result

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The real issue is, that the avatar border style does not match the header background color.

What is the root cause of that problem?

The money report header uses AvatarWithDisplayName to show the avatar which will render MultipleAvatars. The second avatar style has a border color of highlightBG #07271F.

App/src/components/AvatarWithDisplayName.js

Lines 112 to 116 in c20c387

	<MultipleAvatars
	icons={icons}
	size={props.size}
	secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.highlightBG)]}
	/>

However, the header has a transparent background which then shows the background of the report screen which is appBG #061B09. We can notice the color is different.

The avatar border color is introduced in #22467 and the reason the avatar border color is set to highlightBG is to match the background color of the old money report header.

What changes do you think we should make in order to solve the problem?

We have 2 options.

1. Change the color to appBG.
2. Remove the secondary avatar style as MultipleAvatar already has a default style with a color of componentBG which has the same value as appBG.

I prefer the 2nd option as we did this in HeaderView.

App/src/pages/home/HeaderView.js

Lines 177 to 182 in c20c387

	) : (
	<MultipleAvatars
	icons={icons}
	shouldShowTooltip={!isChatRoom || isChatThread}
	/>
	)}

[joekaufmanexpensify]

I agree there is a border, but not sure that this is actually a bug. Further, you can only really notice the border when significantly zoomed in, like this:

When you're at normal zoom, it just distinguishes between the two avatars, which makes me think this may be intended.

I'm inclined to do nothing here, but curious what @shawnborton thinks?

[bernhardoj]

@joekaufmanexpensify the border is indeed intended, but it should match the background color like it does on the LHN

[shawnborton]

Yeah, that border should match the background color. @grgia I think this was part of the avatar changes you made, are you able to follow up and fix this one quickly?

[joekaufmanexpensify]

Cool cool, sounds good.

[joekaufmanexpensify]

Not overdue

[joekaufmanexpensify]

@grgia Curious how you want to proceed with this. If you don't have the bandwidth, just LMK, and I'll make this external!

[joekaufmanexpensify]

Chatted with Georgia, and we're going to make this one external!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013384dd572fef261e

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatar shouldn't have any border

What is the root cause of that problem?

In AvatarWithDisplayName.js,

secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.highlightBG)]}

We are not using correct shade of green, hence this is the root cause.

What changes do you think we should make in order to solve the problem?

We need to apply this change, replace highlightBG with iconReversed in AvatarWithDisplayName component. This should solve the problem.

<MultipleAvatars
    icons={icons}
    size={props.size}
    secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.iconReversed)]}
/>

What alternative solutions did you explore? (Optional)

NA

Result:

[PiyalAhmed]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a money request, if we open it, in the header, there is a border on the top avater (seconderyAvetar). And the border is of highlighted(Different color than the background). Where the expectation is, the border color should match the background color.

What is the root cause of that problem?

Here, the secondAvaterStyle is set to themeColors.highlightBG
For this style, the border color is not same as the background color.

What changes do you think we should make in order to solve the problem?

We can just set the secondAvaterStyle to themeColors.componentBG or themeColors.appBG
This will solve the problem.

The end result will look like this

What alternative solutions did you explore? (Optional)

We can also remove the secondary avatar style as MultipleAvatar already has a default style with a color of componentBG which has the same value as appBG.

<MultipleAvatars
    icons={icons}
    size={props.size}
/>

As we already did this is HeaderView.js.

App/src/pages/home/HeaderView.js

Lines 177 to 182 in c20c387

	) : (
	<MultipleAvatars
	icons={icons}
	shouldShowTooltip={!isChatRoom || isChatThread}
	/>
	)}

[melvin-bot]

📣 @PiyalAhmed! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[PiyalAhmed]

Contributor details
Your Expensify account email: piyal.salamence@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0197f7733019ff4f22

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[joekaufmanexpensify]

@ArekChr mind taking a look at the proposal here?

[grgia]

Assigning @bernhardoj

[melvin-bot]

📣 @Ahmed-Abdella 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @ArekChr

[joekaufmanexpensify]

I think this one is pending internal review from @grgia

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @bernhardoj got assigned: 2023-09-14 02:24:34 Z
• when the PR got merged: 2023-09-25 11:24:22 UTC
• days elapsed: 7

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix money request header avatar border color does not match header background color #27413

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @bernhardoj requires payment offer (Contributor)
• @Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ArekChr] Determine if we should create a regression test for this bug.
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@ArekChr mind taking care of the checklist this week?

[ArekChr]

• Link to the PR: no PR has been identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

[joekaufmanexpensify]

BZ checklist is complete, all set to issue payment. The PR was not merged within 3 business days. However, @ArekChr approved the PR within 3 business days (on 2023-09-18), and then the internal engineer assigned merged it a bit later on 2023-09-25. Because the delay was on us internally, this still qualifies for a speed bonus. This means we need to pay:

• @bernhardoj $750 - $500 for PR, and $250 speed bonus (paid via Upwork).
• @Ahmed-Abdella - $50 for reporting (paid via Upwork).
• @ArekChr - payment is handled separately.

[joekaufmanexpensify]

@bernhardoj $750 sent and contract ended!

[joekaufmanexpensify]

@Ahmed-Abdella $50 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

[Ahmed-Abdella]

Hi, @joekaufmanexpensify @ArekChr I just noticed that this issue is reproducible in the new UI for the LHN. the border appears for the IOU row in the LHN, check stage to see this, Just click on any IOU row in the LHN to activate the background color and the border will appear. And I believe It is highly noticeable.