[Paid - HOLD for BE fix] Search bar - Another error message for a short time when opening archived chat from search bar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open webiste
2. Click on search icon and find any archived workspace that has some messages in it so that it should be loaded for a short time.
3. While loading this chat, you can see another error message for a short time

Expected Result:

There should not appear another error message for a short time when opening archived chat from search bar

Actual Result:

Another error message for a short time when opening archived chat from search bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.62-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-capture.88.online-video-cutter.com.1.mp4

Screen-Capture.88.mp4

bandicam.2023-09-04.19-16-33-088.mp4

Expensify/Expensify Issue URL:

Issue reported by: @MahmudjonToraqulov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692963972266199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01262419686265c297
• Upwork Job ID: 1701300837881397248
• Last Price Increase: 2023-09-11
• Automatic offers:
• jjcoffee | Reviewer | 26665415
• tienifr | Contributor | 26665416
• mahmudjontoraqulov | Reporter | 26665420

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jscardona12]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search bar - Another error message for a short time when opening archived chat from search bar

What is the root cause of that problem?

This error is not happening just on the search it happens when the reportActions are not save in the browser Onyx IndexDB. The first call it will return null to inititialize and make the component is the dafault props in which in this case the default props brings the defailt message that we are seeing for a short time.

THis is state in the Onyx Code:

What changes do you think we should make in order to solve the problem?

Change the defaultProps to a "charging value" mean while do nott render any message.

What alternative solutions did you explore? (Optional)

We wait to render if the value of archiveReason is "default" in ArchivedReportFooter.js

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01262419686265c297

[sakluger]

Adding external label!

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search bar - Another error message for a short time when opening archived chat from search bar

What is the root cause of that problem?

In

App/src/components/ArchivedReportFooter.js

Line 53 in 52c54f4

const archiveReason = lodashGet(props.reportClosedAction, 'originalMessage.reason', CONST.REPORT.ARCHIVE_REASON.DEFAULT);

if the reportAction is loading, we return the default value for archiveReason. After the action is loaded, it's updated to the new one

What changes do you think we should make in order to solve the problem?

We shouldn't wait to render if the value of archiveReason is "default", because if the archiveReason is actually default, the message can't be shown.

I suggest to wait for the reportClosedAction is loaded.

    if(!props.reportClosedAction.reportActionID){
        return <></>
    }

we can return the empty tag (<></>) or the skeleton here

[jjcoffee]

@jscardona12's proposal doesn't feel so clear to me in the RCA and both solutions lack detail.

Happy to go with @tienifr's proposal as it has the correct RCA and the solution looks good. I'd probably prefer the skeleton rather than just the empty tag. I'm not sure if we need some design input here?

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[robertjchen]

Thanks for the review, I also agree with @tienifr 's proposal 👍 Let's definitely go with the skeleton, and we can always make design improvements later.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @MahmudjonToraqulov 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[sakluger]

Added to vip-vsb project, since all open projects need to be associated with a wave or vip.

[sakluger]

Still on hold.

[robertjchen]

Holing for backend

[robertjchen]

still holding for BE

[sakluger]

@robertjchen any updates?

[sakluger]

@robertjchen bump.

[sakluger]

I'm going to move this to daily and test tomorrow to see if this is even still happening. It's been a long time and we've closed the #vip-vsb project that this was tied to, so we either need to move it to another project, or close the issue.

[tienifr]

@sakluger @robertjchen any updates on this issue?

[sakluger]

I was able to reproduce this, but the temporary error message appeared for less than a second. I honestly don't think this is worth fixing right now because most users won't be searching for archived chats, and even if they do and the wrong error message flashes briefly, it doesn't really negatively impact the user experience.

Based on my reasoning above, I vote to close the issue. @jjcoffee @tienifr @robertjchen do any of you disagree?

@jjcoffee I don't have a good sense of how much work was done on this issue. If we close the issue, is anyone due payment?

[jjcoffee]

@sakluger The original fix was reverted due to pending required BE changes (this comment has some context). Payment was already made on that basis, but the BE fix was never made.

[sakluger]

Oh yeah - I even updated the title to remind myself that this was already paid out 🤦‍♂️ .

I'll post one more time in Slack to see if we want to finish the BE piece or if we should just close it.

[sakluger]

As recommended, I am moving this to #quality as a LOW priority project. I will unassign @robertjchen and move back to monthly. That way, if a BE engineer is looking for an issue to work on, they'll see that it's available.