[HOLD for payment 2023-09-27] [$500] Chat - Emojis are selected when message is copied by selecting

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Send any text and add emojis
3. Copy text by double clicking and paste in composer

Expected Result:

Emojis should not be copied with text

Actual Result:

Emojis are be copied with text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• Windows / Chrome

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Monosnap.screencast.2023-08-30.20-07-25.mp4

Recording.32.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Krishna2323

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693406411674209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141e82a06a4ba237b
• Upwork Job ID: 1699027373879193600
• Last Price Increase: 2023-09-12
• Automatic offers:
• 0xmiroslav | Reviewer | 26659187
• bernhardoj | Contributor | 26659189
• krishna2323 | Reporter | 26659191

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Emojis are selected when message is copied by selecting

What is the root cause of that problem?

Seems like a react-native bug, the root cause still is not very clear to me but removing styles.userSelectNone solves the problem.

What changes do you think we should make in order to solve the problem?

We need to remove styles.userSelectNone from EmojiReactionBubble.js. Slack & Whatsapp also doesn't block emoji from selection.

App/src/components/Reactions/EmojiReactionBubble.js

Lines 87 to 88 in d2bdaec

	<Text style={[styles.emojiReactionBubbleText, styles.userSelectNone, StyleUtils.getEmojiReactionBubbleTextStyle(props.isContextMenu)]}>{props.emojiCodes.join('')}</Text>
	{props.count > 0 && <Text style={[styles.reactionCounterText, styles.userSelectNone, StyleUtils.getEmojiReactionCounterTextStyle(props.hasUserReacted)]}>{props.count}</Text>}

Result

fixed_demo.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141e82a06a4ba237b

[MitchExpensify]

Lets fix this!

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[payal-lathidadiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Emojis are selected when message is copied by selecting

What is the root cause of that problem?

Issue is due to accessibilityLabel attribute added for element here.

What changes do you think we should make in order to solve the problem?

Replace style of userSelectNone to userSelectText in EmojiReactionBubble component here while rendering emoji reaction element.

What alternative solutions did you explore? (Optional)

Alternatively, we can also remove this style userSelectNone

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Triple-clicking the chat message will copy over the reaction emoji if exists.

What is the root cause of that problem?

This is another issue of a browser bug where user-select: none can be selected/copied to the clipboard which we already encounter a few times #24156 #17838.

What changes do you think we should make in order to solve the problem?

Add dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}} to both AddReactionBubble and EmojiReactionBubble to ignore the emoji from the selection.

As we already encountered this a few times, I think it's good to implement the solution to the component that is supposed to be non-selectable, for example, edited space text (in EditedRenderer and ReportActionItemFragment), MiniQuickEmojiReactions, BaseSelectionList Select all, Checkbox/RadioListItem, etc.

[MitchExpensify]

Bump on reviewing these proposal @0xmiroslav, thanks

[melvin-bot]

@MitchExpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@MitchExpensify, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@MitchExpensify, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

Bump @0xmiroslav 🙇

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[0xmiros]

I like @bernhardoj's proposal to reuse current solution already applied to other parts.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Li357]

Agreed, @bernhardoj all yours!

[bernhardoj]

PR is ready

cc: @0xmiroslav

[melvin-bot]

🎯 ⚡️ Woah @0xmiroslav / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-13 18:54:32 Z
• when the PR got merged: 2023-09-18 05:52:53 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Ignore unselectable text from selection #27421

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @0xmiroslav requires payment offer (Reviewer)
• @Krishna2323 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

Reporter: $250 @Krishna2323 Upwork
C: $750 @bernhardoj Upwork
C+: $750 @0xmiroslav Upwork

Added a reminder to my cal to pay out

[MitchExpensify]

Payment summary:

Reporter: $250 @Krishna2323 Upwork PAID
C: $750 @bernhardoj Upwork - PAID
C+: $750 @0xmiroslav Upwork - Bump on BZ steps and accepting Upwork offer @0xmiroslav

[Krishna2323]

@MitchExpensify, why $250 for reporter role👀

[0xmiros]

@MitchExpensify, why $250 for reporter role👀

Not sure @MitchExpensify already checked but you're luckily eligible for original price. Your reported this bug in slack 5 hrs earlier than price announcement.

[0xmiros]

Bump on BZ steps and accepting Upwork offer @0xmiroslav

BZ Checklist: I propose same as #24156 (comment)

Accepted offer

[MitchExpensify]

Not sure @MitchExpensify already checked but you're luckily eligible for original price.

I actually had not haha, thanks for doing that for me @0xmiroslav !

[melvin-bot]

@Li357, @MitchExpensify, @bernhardoj, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Everyone is paid, no BZ steps needed, closing. Thanks, all!