[HOLD for payment 2023-09-27] [$500] Prevent the route to be fetched if the list of valid waypoints are not changed

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a workspace chat
2. Click on the "+" icon next to the text composer
3. Select "Request money" and then choose "Distance"
4. Add addresses for "Start" and "Finish"
5. Click on "Add stop".
6. Confirm the route is re-drawn (the route disappears momentarily and then appears again), indicating that the route is fetched again.

Expected Result:

The route should not be fetched or redrawn when the list of valid waypoints don't change.

Actual Result:

The route is refetched and redrawn.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on? -> Only checked in iOS, but the issue should be present on other platforms

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-06.at.08.28.00.mov

Expensify/Expensify Issue URL:
Issue reported by: Internal engineer
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fca27c4e249aa0e
• Upwork Job ID: 1701113718051364864
• Last Price Increase: 2023-09-11
• Automatic offers:
• akinwale | Contributor | 26687261

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fca27c4e249aa0e

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[akinwale]

@hayata-suenaga If we remove an empty waypoint, the route is being fetched for that as well. Do we want to handle this case as well in this PR? Or do you think its fine to refetch the route after deleting an empty stop?

Looking at this scenario, I reckon it makes sense to check if the stop is empty before clearing the route. If the deleted stop / waypoint is empty, do not clear the route, otherwise clear the route and let the recalculation happen.

Let me know what you think about this.

[hayata-suenaga]

@akinwale It think that's a great idea. Can you handle that logic, too in your PR?

[akinwale]

@akinwale It think that's a great idea. Can you handle that logic, too in your PR?

Sure thing.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[akinwale]

@allroundexperts My PR is ready for review. Thanks.

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @akinwale, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @akinwale got assigned: 2023-09-15 05:42:54 Z
• when the PR got merged: 2023-09-18 09:17:55 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent a route refresh if the list of valid waypoints have not changed #27496

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Payouts due:

Issue Reporter: N/A
Contributor: $750 @akinwale
Contributor+: $750 @allroundexperts - can request once the checklist is filled out, thanks!

Eligible for 50% #urgency bonus? Y

[allroundexperts]

I don't think that this kind of network call optimisation can be tested by test rail. As such, the regression test is not required here. @JmillsExpensify Please let me know if you'd disagree.

[JmillsExpensify]

No disagreement from me. Sounds good!

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.