[HOLD for payment 2023-09-27] [$500] Login - /r/undefined shows in address bar after login new account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Logout if already logged in
2. Login with new email
3. Observe browser address bar

Expected Result:

Url shouldn't show /undefined

Actual Result:

Url shows /undefined

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.66-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Undefined.mp4

Recording.6167.mp4

Expensify/Expensify Issue URL:

Issue reported by: @situchan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693317302453489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b8fbd47ec15094c
• Upwork Job ID: 1701538687565389824
• Last Price Increase: 2023-09-12
• Automatic offers:
• bernhardoj | Contributor | 26666941
• situchan | Reporter | 26666943

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rmm-fl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Url shows /r/undefined

What is the root cause of that problem?

App/src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator.js

Line 21 in fc8adf9

initialParams={{openOnAdminRoom: openOnAdminRoom ? 'true' : undefined}}

In the initial params for the route from CentralPaneNavigator, the reportID is not assigned so it default to undefined.

What changes do you think we should make in order to solve the problem?

Update the initialParams to use the reportID from url if it exists or set it to empty.

initialParams={{
    openOnAdminRoom: openOnAdminRoom ? 'true' : undefined,
    reportID: ReportUtils.getReportIDFromLink(url) ?? '',
}}

What alternative solutions did you explore? (Optional)

--

[situchan]

@rmm-fl thanks for your proposal. Could you find out the offending PR? This is a recent regression (within a month or so)

[situchan]

@situchan I don't think @rmm-fl proposal has a correct RCA because this only happen with the new account.

I didn't say their RCA is correct 😄
Also, this happens on existing account as well (see @izarutskaya's video)

[dukenv0307]

@situchan My bad I just tested with the existing account, and also has the same issue.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

r/undefined is shown in the params after login.

What is the root cause of that problem?

The report route pattern requires reportID to be present.

App/src/ROUTES.js

Line 68 in 153ab36

REPORT_WITH_ID: 'r/:reportID/:reportActionID?',

However, after logging in, we don't have any report yet, so the reportID is empty, and thus undefined is showing. Previously, the reportID is optional, but gets changed in #24411. I think it's a bad merge because at the time of the proposal of the PR, reportID is indeed required.

Why it is previously required but works fine? That's because on the old code, if the reportID is empty, we render FullScreenLoadingIndicator instead of ReportScreen, so after login, the URL will be staging.new.expensify.com without /r

What changes do you think we should make in order to solve the problem?

Make the reportID params optional again.

What alternative solutions did you explore? (Optional)

Set the initialParams of reportID in CentralPaneNavigator to be an empty string.

[melvin-bot]

@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b8fbd47ec15094c

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[laurenreidexpensify]

Not overdue

[thesahindia]

@bernhardoj's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @thesahindia

[melvin-bot]

🎯 ⚡️ Woah @thesahindia / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-14 05:16:04 Z
• when the PR got merged: 2023-09-15 03:47:37 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix undefined shows in URL after log in #27423

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @thesahindia does not require payment (Eligible for Manual Requests)
• @situchan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment summary:

• Bug Reporter > @situchan $50, paid on Upwork
• Contributor > @bernhardoj $500 + 50% urgency bonus, $750, paid on Upwork
• Code Review > @thesahindia $500 + 50% urgency bonus, $750, to be requested in NewDot

[laurenreidexpensify]

@thesahindia what are you thinking for regression steps?

[bernhardoj]

@laurenreidexpensify I didn't receive the 50% bonus. Can you please check it?

[laurenreidexpensify]

Sorry @bernhardoj - corrected!

[laurenreidexpensify]

Just waiting on @thesahindia for checklist + regression steps above

[bernhardoj]

@laurenreidexpensify Thanks!

[thesahindia]

Just waiting on @thesahindia for checklist + regression steps above

I think we can skip the checklist because we can't call it a regression.

If we want we can add test case. Steps -

1. Sign out if you are signed in
2. Sign-in to the app
3. After successfully signing in, verify the URL is shown as staging.new.expensify.com/r (no /r on mobile web)

[laurenreidexpensify]

Closing

[JmillsExpensify]

$750 payment approved for @thesahindia based on this summary.