[HOLD for payment 2023-10-02] [$500] Chat - Flag as offensive page does not disappear when deleting the Message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From User A Send a message to User B.
2. From User B, Go to reply in thread on the message sent from User A. > Then Click on Flag as Offensive button from the reaction menu.
3. Now Delete the message from User A while the Flag as offensive page is still open from User B.

Expected Result:

The opened Flag as offensive page from User B. should be closed when User A deletes the message. It should show the Page Not Found error message.

Actual Result:

The Flag as offensive page remains open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T123-Flagas.mp4

Recording.1487.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692641567668079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f9ee295f5f5cd370
• Upwork Job ID: 1702099690396909568
• Last Price Increase: 2023-09-13
• Automatic offers:
• 0xmiroslav | Reviewer | 26722920
• tienifr | Contributor | 26722922
• daveSeife | Reporter | 26722924

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Flag comment page does not dismiss when comment is deleted.

What is the root cause of that problem?

ATM, FlagCommentPage only subscribes to reportActions of the current report in Onyx. However, in this case, it's a child report, thus any changes to the actual (parent) report action does not propagate to the page.

App/src/pages/FlagCommentPage.js

Line 181 in 5c13816

export default compose(withLocalize, withReportAndReportActionOrNotFound)(FlagCommentPage);

I don't think we should dismiss the RHP but show Not found page on deletion instead. That's consistent with normal comments.

What changes do you think we should make in order to solve the problem?

Subscribe FlagCommentPage to parent report actions:

 withOnyx({
    parentReportActions: {
        key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID || report.reportID}`,
        canEvict: false,
    },
})

Thus on deletion, RHP would show Not found page.

There's no way to determine whether this is a child report thus I use report.reportID as the fallback id.

What alternative solutions did you explore? (Optional)

In case we want to not show anything, just keep the page open, remove props.report and props.reportActions from the dependencies of getActionToFlag, so it won't get called again for any changes:

App/src/pages/FlagCommentPage.js

Line 123 in 5a153a3

}, [props.report, props.reportActions, props.route.params.reportActionID]);

[jliexpensify]

I can repro this, but I am not convinced this is a bug - it seems like it's a delay. I'm asking the Engineer who implemented the Flag as offensive button for a second opinion!

[tienifr]

Normally for a report action, the flag page shows Not found on message deletion. But thread comment is not. I think we should fix this for consistency.

flag-compressed.mov

[jliexpensify]

@tienifr @daveSeife - I just spoke to Daniel, who implemented the Mark as offensive feature, and confirmed that this behaviour is intentional (comment here)

We chose not to fix it in #20674, so the same goes here.

[tienifr]

if the flag page is already open when the message gets deleted, then keep it open and do nothing when an option is chosen

@jliexpensify Seems like something has changed, when I deleted the attachment, the flag comment page would show Not found:

flag-comment-compressed.mov

It's the same for all other comments:

flag-compressed.mov

Only thread first comment is not. As explained in my proposal, we should show not found page for thread comments on deletion as well to maintain consistency (not close it as in the issue description).

In case we want to not show anything, just keep the page open, I've provided a solution for that in the alternative solution part.

cc: @dangrous

[jliexpensify]

Spoke to Daniel again, we'll fix this for consistency's sake.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f9ee295f5f5cd370

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[tienifr]

@jliexpensify Just want to confirm the expected behavior here. Do we want to leave the flag page as is; or show not found page on deletion?

[jliexpensify]

@dangrous - my assumption is that we'd want to be consistent across the board, so we'll show page not found upon deletion of the offensive comment. Can I confirm this is what you're thinking too? Thanks!

[dangrous]

yep! show not found

[0xmiros]

@tienifr's proposal (main solution) looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

Looks good to me as well, assigning you to the issue @tienifr

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[tienifr]

PR ready for review: #27656.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-09-18 00:55:59 Z
• when the PR got merged: 2023-09-21 03:06:08 UTC
• days elapsed: 3

On to the next one 🚀

[0xmiros]

Hope this would be eligible for efficiency bonus as C+ approved PR in 2 days 15 hrs and there were no changes requested.
cc: @srikarparsi

[jliexpensify]

It should, I'd imagine!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Flag comment page does not show Not found when delete thread's first comment #27656

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Sorry, missed this! @0xmiroslav can you complete the checklist please?

[jliexpensify]

Payment Summary:

• Bug Reporter: @daveSeife $50
• Contributor: @tienifr $500 + $250
• C+: @0xmiroslav $500 + $250

Upwork job

[0xmiros]

This is kind of "dynamic update" issue and the bug always existed after flag implementation.
As this is unusual case, I propose no regression test.

[jliexpensify]

All paid except for @0xmiroslav . Did you want me to close this?

[0xmiros]

yes please