[Hold for Payment] [$1000] mWeb- Compose-Adding hyphen in url, although invalid shown as link and editing shows different forma

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap any report
3. Enter -77.com
4. Send the message
5. Long press the sent message
6. Tap edit comment
7. Enter -77.com [slash add before dot com]
8. Tap tick
9. Long press the message
10. Tap edit comment

Expected Result:

When user sends -77.com, then edits this comment, it must be displayed in same format
-77.com

Actual Result:

When user sends -77.com , it is shown as link. And when user edit this comment, it is displayed in different format -77.com

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6193588_hyphen.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation:@

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0185d689f506bdc532
• Upwork Job ID: 1701603965592113152
• Last Price Increase: 2023-10-13

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0185d689f506bdc532

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Applying External

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb- Compose-Adding hyphen in url, although invalid shown as link and editing shows different forma

What is the root cause of that problem?

There are two potential issues here, the root cause is the over-generosity of our regular expressions. Specifically:

- Patterns permitted domain names to start or end with a hyphen.
- Patterns also allowed URLs without a valid top-level domain to pass through. eg: https://nothingafter

What changes do you think we should make in order to solve the problem?

To rectify these inaccuracies, we made the following updates to the regular expressions:

For URL_WEBSITE_REGEX:

https://github.com/Expensify/expensify-common/blob/7735de14112a968fd6a4f5af710d2fbaefc8809d/lib/Url.js#L5

Adjusted to necessitate domain names to begin and conclude with a lowercase letter or number, with the flexibility of having word characters or hyphens in the middle. This change ensures the validity of the domain name part of the URL.
These modifications will ensure the exclusion of URLs with domains that begin or end with hyphens and those without a valid top-level domain.

Updated:
const URL_WEBSITE_REGEX = ${URL_PROTOCOL_REGEX}?((?:www\.)?[a-z0-9][-a-z0-9]*[a-z0-9]\.)+(?:${TLD_REGEX})(?:\:${ALLOWED_PORTS}|\b|(?=_))(?!@(?:[a-z\d-]+\.)+[a-z]{2,});

For LOOSE_URL_WEBSITE_REGEX:

https://github.com/Expensify/expensify-common/blob/7735de14112a968fd6a4f5af710d2fbaefc8809d/lib/Url.js#L14

Updated to require domain names to start and end with a lowercase letter or number.
Made the presence of a valid top-level domain mandatory after the period.

Updated:
const LOOSE_URL_WEBSITE_REGEX = ${URL_PROTOCOL_REGEX}([a-z0-9][-\w]*a-z0-9+)(?:\:${ALLOWED_PORTS}|\b|(?=_));

Result:

fixed.mp4

[melvin-bot]

@greg-schroeder, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[greg-schroeder]

awaiting proposal review

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@greg-schroeder, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@greg-schroeder @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

Any chance you're able to take a look @allroundexperts? Thanks!

[allroundexperts]

I don't think that the expected result is correct here. At least, the first part of it. Entering -77.com in slack also results in a link of 77.com similar to our app. @Krishna2323 Can you update your proposal to handle the second part only? I think that is the bug here.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tsa321]

@allroundexperts how about http://localhost? Isn't it valid url/link?

[byte1012]

@greg-schroeder @allroundexperts
The App PR #31346 is ready

[greg-schroeder]

Looks like this was deployed to prod 5 days ago, not sure what's up with the automation 🤔

[greg-schroeder]

Although this one wasn't deployed at all afaict: Expensify/expensify-common#598

This one is weird because of the unusual merging/review situation - can anyone help confirm what's left before this can be considered finished up?

[allroundexperts]

@greg-schroeder Expensify/expensify-common#598 doesn't need to be deployed as its just a package. The second PR actually applied the changes of the first PR into our App. This is finished already.

[greg-schroeder]

Okay sorry for the delay on this one, there's no automation at all so my filters keep ignoring this issue. Let me go through and figure out what's left to do here so we can close it.

[greg-schroeder]

PR 1: #31346
PR 2: Expensify/expensify-common#598

Reporter: QA / NA
Contributor was @byte1012
C+ was @allroundexperts

So this was eventually upgraded to $1k, so I will send a manual offer to @byte1012 for this one. Sibtain you can make a manual request for $1k for the reviewer role.

[greg-schroeder]

@byte1012 can you follow the steps here so I can pay you? Thanks!

[greg-schroeder]

You could also apply for the job I made here: https://www.upwork.com/ab/applicants/1736927955655499776/job-details

Just please confirm your name/upwork profile for future reference

[allroundexperts]

Checklist

1. fix: add support for localhost urls in markdown expensify-common#535
2. https://github.com/Expensify/expensify-common/pull/535/files#r1431325869
3. N/A
4. A regression test would be overkill in this case since we've covered this particular case in the unit tests pretty comprehensively.

[greg-schroeder]

Thanks!

[greg-schroeder]

Bump @byte1012

[greg-schroeder]

Trying to get this contributor's details: #26941 (comment)

[byte1012]

Contributor details
Your Expensify account email: kelleyaquilino@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f484b51cfedb480a

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[byte1012]

@greg-schroeder done. sorry about delay. I missed this issue for a while

[byte1012]

@greg-schroeder could you send me an offer on upwork ?

[greg-schroeder]

@byte1012 offer sent

[greg-schroeder]

Once you're able to accept we'll close this out!

[greg-schroeder]

Paid!

[JmillsExpensify]

$1,000 payment to @allroundexperts based on this comment.