[$500] [Distance] - Automatic Saving of Start or End Point and Redirection to Distance Page Renders Save Button Useless

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click the plus sign and select "Request Money."
2. Go to the Distance page and input a start or end point. Observe that the app saves the location automatically without requiring the user to click Save. Furthermore, selecting a start point redirects the user to the Distance page instead of staying on the current page until saved.

Expected Result:

The Save button should either work correctly or be removed. When a start or end point is selected, the location should be chosen but not saved until the user clicks Save. The app should remain on the current page until the user decides to save and then redirect to the Distance page.

Actual Result:

Selecting a start or end point automatically saves the location and redirects to the Distance page, making the Save button unnecessary.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-05T045157.755.webm

Recording.4364.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693914355944309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110ac5e7e0555b43d
• Upwork Job ID: 1700877906162176000
• Last Price Increase: 2023-09-10
• Automatic offers:
• DylanDylann | Contributor | 26660141
• tewodrosGirmaA | Reporter | 26660142

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance]Automatic Saving of Start or End Point and Redirection to Distance Page Renders Save Button Useless

What is the root cause of that problem?

When selecting the address, the App will redirect to Distance request Page by this logic

App/src/pages/iou/WaypointEditor.js

Line 157 in 57b7606

Navigation.goBack(ROUTES.getMoneyRequestDistanceTabRoute(iouType));

What changes do you think we should make in order to solve the problem?

We should hide the save button in the WaypointEditor Page
To do that

App/src/pages/iou/WaypointEditor.js

Line 193 in 57b7606

<Form

Here, we add

isSubmitButtonVisible={false}

and remove redundant props like submitButtonText, onSubmit...

What alternative solutions did you explore? (Optional)

when selecting option, we don't navigate back by removing this line

App/src/pages/iou/WaypointEditor.js

Line 157 in 57b7606

Navigation.goBack(ROUTES.getMoneyRequestDistanceTabRoute(iouType));

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0110ac5e7e0555b43d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[namhihi237]

I think it will be fixed #27021

[heykulthe]

Wanted to contribute on this one... but I guess it's taken :(

[melvin-bot]

📣 @iamsid47! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[heykulthe]

Contributor details
Your Expensify account email: siddheshkulthe43@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01436626654ff57e2c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[MbuguaGeorge]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] - Automatic Saving of Start or End Point and Redirection to Distance Page Renders Save Button Useless

What is the root cause of that problem?

/App/src/pages/iou/WaypointEditor.js

What changes do you think we should make in order to solve the problem?

To address the problem, we should consider removing this line. Instead, we should implement the redirection behavior exclusively when the save button is clicked. This approach maintains consistency, especially since the save button is currently designed to function offline.

What alternative solutions did you explore? (Optional)

N/A

Screencast.from.10-09-23.19.36.49.webm

[melvin-bot]

📣 @MbuguaGeorge! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MbuguaGeorge]

Contributor details
Your Expensify account email: mbuguageorge026@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5c31c1a719ec270

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[tewodrosGirmaA]

I think it will be fixed #27021

Not the same bug ,it is different

[abekkala]

@robertKozik can you confirm if the fix for this will be fixed via #27021 or not

[robertKozik]

@abekkala I'm also a C+ on #27021. Chosen proposal does not contain removing the save button, as it should only address saving waypoints in offline mode. That's why I think we should fix this issue individually, but as this would contain only removing the submit button or removing redirect function, we can consider reducing the bounty due to simplicity of this issue

[robertKozik]

Thank you all for your proposals! 🙇🏼
Both proposals here correctly pinpointed the root cause and proposed the same solutions. As @DylanDylann proposal was the quickest I think you should be assigned to this issue.

Moreover as in issue #27021 we will probably remove the possibility of typing random waypoint in offline mode, the save button will become obsolete in every scenario as choosing waypoint from the list will trigger the redirect, so we should go with your main proposed solution - removing the submit button

Selected Proposal: Proposal
Contributor: @DylanDylann

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @tewodrosGirmaA 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[DylanDylann]

@robertKozik The PR is ready for review

[robertKozik]

Hello!

I'm following up on issue #27021. It seems that saving from the autocomplete dropdown should be an option for offline flows. Since I don't have access to the Slack conversation mentioned in this comment, could we please double-check whether this behavior is indeed a bug or if it's intended?
CC. @tgolen @abekkala

[DylanDylann]

@thienlnam I see that you implement offline flow in distance request. So could you help to check this comment ?

[tgolen]

@robertKozik I think everything is fine here. This issue is only about removing the save button because it functionally has no purpose since everything is automatically saved when you select a waypoint.

#27021 Is about being able to select an invalid waypoint when you are offline.

Maybe I'm not quite understanding your question, but I don't see how these are directly related.

could we please double-check whether this behavior is indeed a bug or if it's intended?

Could you please clarify what "this behavior" is that you are asking about? I'm not sure what it's referring to.

[thienlnam]

Yeah, it's possible to enter in a waypoint offline - so I don't think this is a bug and we can close.

We could remove the save button while you're online? But I don't really see the need to update that flow

[DylanDylann]

@tgolen @robertKozik please help to take a look at this comment when you are free? And then we can move forward with this issue

[tgolen]

It's just so weird to leave a button there when it has zero functionality. I'd remove it.

[DylanDylann]

@tgolen when offline, there are no suggestion address for user. So user only can enter address manually and click save button

[thienlnam]

It's just so weird to leave a button there when it has zero functionality. I'd remove it.

It is not required for the online flow, but is required for the offline flow. Are you suggesting removing it for just the online flow?

[tgolen]

OK, I understand now. If it's needed for one of the flows, let's leave it there for both flows and we can just close this.

…

On Mon, Sep 25, 2023 at 10:06 AM Jack Nam ***@***.***> wrote: It's just so weird to leave a button there when it has zero functionality. I'd remove it. It is not required for the online flow, but is required for the offline flow. Are you suggesting removing it for just the online flow? — Reply to this email directly, view it on GitHub <#27108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB7NVFZ4LU4XCNO6HW3X4DRIZANCNFSM6AAAAAA4SGZOIQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tewodrosGirmaA]

hello @abekkala , i get an offer but payment is not settled

[DylanDylann]

@abekkala Are we eligible for compensation for our effort? Contributors are already assigned and started on the PR. It's just due to the expectation changes and the solution becomes outdated.

Some other similar cases where compensation is made are below:
#18664 (comment)
#21419 (comment)

[abekkala]

based on this #18664 (comment)

Sending payment offers to

• @tewodrosGirmaA [$50]
• @DylanDylann [$500]

---

• @robertKozik [no payment - software mansion]

[abekkala]

@tewodrosGirmaA [$50] - payment sent and contract ended

@DylanDylann [$500] - payment sent and contract ended

[tewodrosGirmaA]

Thank you @abekkala 😊