[HOLD for payment 2023-10-09] [$500] Assign task - App allows to add anything ahead of confirm task URL and maintains the same URL throughout the process

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on assign task
3. Add any title and click Next
4. Click on share somewhere and copy the URL
5. Change the 'share-destination' part of URL to anything and send the modified URL to any chat
6. Open the URL and observe that it opens confirm task page
7. Open any tab, save anything and observe that confirm task URL still has newly added text added in step 5

Expected Result:

App should display 'Hmm its not here' page or redirect to proper task page if we add any incorrect text ahead of confirm task URL

Actual Result:

App opens confirm task page and maintains incorrect URL even on saving or editing any field when we add random text ahead of confirm task URL

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.69-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

maintains.wrong.URL.throughout.task.flow.mp4

Recording.6228.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694015574809879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b8f51527c83f586
• Upwork Job ID: 1701974239937085440
• Last Price Increase: 2023-09-20
• Automatic offers:
• dukenv0307 | Contributor | 26797065
• Dhanashree-Sawant | Reporter | 26797070

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b8f51527c83f586

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App allows to add anything ahead of confirm task URL and maintains the same URL throughout the process

What is the root cause of that problem?

The new task page has the route with the reportID params as an option. So with the URL new/task/:any, it mean :any is the reportID param and the URL is vaid with the NewTaskPage

App/src/ROUTES.ts

Line 125 in d494433

NEW_TASK_WITH_REPORT_ID: `${NEW_TASK}/:reportID?`,

What changes do you think we should make in order to solve the problem?

Actually now, in the new task flow, the URL is always new/task even we create it in a report. So we should change the route of NewTaskPage to NEW_TASK to make the invalid URL of NewTaskPage will display not found page

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.13-09-2023.22.46.04.webm

[eVoloshchak]

Actually now, in the new task flow, the URL is always new/task even we create it in a report. So we should change the route of NewTaskPage to NEW_TASK to make the invalid URL of NewTaskPage will display not found page

This is correct, looking at the code I can't find a case where reportID would be included in the URL when creating a new task
@dukenv0307's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[eVoloshchak]

Not overdue, waiting on @aldo-expensify's review of this

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[dukenv0307]

@eVoloshchak The PR is ready to review.

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-09-21 12:36:33 Z
• when the PR got merged: 2023-09-26 09:20:18 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Edit the route of new task page #27909

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay out on the 9th.

[MitchExpensify]

Payment summary:

$750 - @eVoloshchak (Eligible for Manual Requests)
$750 - @dukenv0307 requires payment offer (Contributor)
$250 - @dhanashree-sawant requires payment offer (Reporter)

[MitchExpensify]

Paid @dukenv0307 & @dhanashree-sawant.

Bump on BZ steps @eVoloshchak

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: this was the initial implementation in Handle navigation for Tasks Page #17322, but according to this comment NOTE: This page is going to be updated in https://github.com/Expensify/App/issues/16855, this is just a placeholder for now, so I wouldn't call this a regression, rather an edge case that wasn't accounted for initially
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this was just missed during the initial implementation
• Determine if we should create a regression test for this bug.
  This is an edge case that isn't reproducible during normal app usage (you have to manually enter an invalid URL), I think regression test isn't needed here

[MitchExpensify]

Thanks! Closing as all that remains is @eVoloshchak's payment which will happen regardless of this being open 👍

[JmillsExpensify]

$750 payment approved for @eVoloshchak based on BZ summary.