[$500] IOS - iOS app crashes when switching chats (and sometimes when launching)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap into 1 or more chats
3. It crashes

Expected Result:

App should not crash

Actual Result:

App is crashing consistently the past few days when I’m simply chat switching, or launching the app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1695250512.MP4

Expensify/Expensify Issue URL:
Issue reported by: @michaelhaxhiu
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695250716424909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01884be58254438c7f
• Upwork Job ID: 1706502088914329600
• Last Price Increase: 2023-09-26

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

Bumped the Slack thread to see if this is still happening for Hax.

[michaelhaxhiu]

Yes it's still happening. I reproduced last week, yesterday, and again this morning.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01884be58254438c7f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[lschurr]

@burczu would you double check this and see if it's reproducible? Not sure if this is widespread or just specific to Hax's device/account.

[spectusAkashIOS]

Proposal

The app is getting crashed when switching from one chat to another on the chat listing screen.

Checked the Video Recording attached with the issue.

Root cause
To find the exact cause of the issue, need to debug the app and find the line of code or object which is causing the app to crash.

Majorly and most common cause can be a - unwrapping or using a value of Nullable variable forcefully and it is causing crash when value is NULL.

Proposed Solution:
Most of the time, crash caused by unwraping a NULL value from a varibale or an object. This can be handled by using

guard let <statement> else {
return
} 

Or can be handled via

if let abc = NullableVariable {
//handle value of abc here
}

If the crash is caused by any other reason, it can be identified via debug.

Contributor details
Akash Patel (akashpatel116@gmail.com)
Upwork Profile Link: https://www.upwork.com/freelancers/~01481520e615cc06af

[melvin-bot]

📣 @spectusAkashIOS! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[burczu]

@spectusAkashIOS Your proposal does not follow our Proposal Template - please update it accordingly. Moreover, what you posted is not actually a proposal - it's just an advice how to find the issue. We need a detailed description what is the issue and how exactly we can fix it in your proposal.

[spectusAkashIOS]

Comment updated @burczu

[burczu]

@spectusAkashIOS Ok, it follows the template now, but it's still not a proposal. What we expect is instead saying "we have to debug and check what is wrong" we need something like "I debugged, did some research, found an issue here and there and to fix it we need to change this file this way, and that file this way etc.".

[spectusAkashIOS]

ok @burczu , I will update comment after debug.

[burczu]

@lschurr I wasn't able to reproduce it (checked on the simulator).

[sonialiap]

I wonder if this issue is the same as one Applause found #28068. @michaelhaxhiu does the video in the issue I linked look like the behavior you're seeing?

[burczu]

@sonialiap I rather think it may not be the same cause here and in the bug you've mentioned. Here the app crashes completely, and there the issue is handled by the app itself showing the error message (but it happens in the web version of the app so it may be the reason). In fact it's hard to say without deeper investigation.

[tienifr]

This might be a dupe of #27392 but I'm not sure about #28068. This is related to timezones. I had a proposal there.

@michaelhaxhiu Would you mind sharing the timezones of your current account as well as other participants in the chat you have switched to in the video?

[michaelhaxhiu]

Wowie this is not reproducible anymore, which tbh I'm happy about (the app was 100% unusable for over 1 week for me!). I tried to tap into a bunch of unreads in the LHN and chat switching to new/existing users with the 🔎 search.

Let's close it! Something fixed it. I made sure to update to latest version and ensure it's working.