[HOLD for payment 2024-01-18] [$250] Dev: IOS - App crashes when opening a transaction report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the ios app
2. Open an iou report that has transactions
3. Click on a transaction to open the transaction report

Expected Result:

App does not crash

Actual Result:

App crashes with console error: Render Error Invalid time value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.69.1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-09-13.21-46-10.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694440628004359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010d24045ce9cc8210
• Upwork Job ID: 1716907956821823488
• Last Price Increase: 2024-06-27
• Automatic offers:
• situchan | Reviewer | 28015222
• tienifr | Contributor | 28015224

Issue Owner

Current Issue Owner: @

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e5e93003759619c

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[tienifr]

I reported this bug a long time ago here: https://expensify.slack.com/archives/C049HHMV9SM/p1693349618431379.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - App crashes when opening a report

What is the root cause of that problem?

This is due to our migration from momentjs to date-fns library recently. One of the participants of that report may have a deprecated timezone in momentjs that is not supported in date-fns. In this case it is Etc/GMT-1 and Asia/Saigon. This is explained in momentjs documentation:

Some libraries use the ECMAScript Intl API for locales, time zones, or both.
Some libraries still provide their own locale and time zone files like Moment and Moment-Timezone do.

date-fns belongs to the Intl group.

However, there might be differences in implementing this Intl across browsers/runtimes. Although they use the same Intl interface, some timezones are supported on one device but not the others. For example, I tried this code to validate a timezone:

Intl.DateTimeFormat(undefined, { timeZone: 'Asia/Saigon' })

but Mac Chrome and iOS yielded different results: success and error. This is a known issue of Hermes: facebook/hermes#23. That's why the app only crashed on iOS but not Web. One more thing is that because momentjs supports almost all IANA timezones, the issue has not happend before.

There've been efforts to add polyfills for this Intl.DateTimeFormat interface for native here:

App/src/libs/IntlPolyfill/index.native.js

Line 12 in 099fac6

require('@formatjs/intl-datetimeformat');

But that only implemented the core functions of DateTimeFormat, not the actual polyfills to support ECMA-402.

What changes do you think we should make in order to solve the problem?

Add support for all IANA timezones using formatjs (reference) for iOS platform:

require('@formatjs/intl-datetimeformat/polyfill-force');
require('@formatjs/intl-datetimeformat/add-all-tz');
require('@formatjs/intl-datetimeformat/locale-data/en');
require('@formatjs/intl-datetimeformat/locale-data/es');

[DylanDylann]

I also see this bug on the IOS App (production version). It seems this bug is serious

[NicMendonca]

@situchan proposal here for you! ^^

[NicMendonca]

bump @situchan ^

[tienifr]

FYI, this is the supported timezones on iOS and former momentjs.

[melvin-bot]

@NicMendonca, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

reviewing today

[melvin-bot]

@NicMendonca, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

@tienifr proposal looks promising but do you have clear repro step?

[tienifr]

@situchan You could try this:

1. Change your IP location by a VPN service (UrbanVPN is a great & free one) then switch to one of the affected locations (Vietnam for example)
2. Open Web app on Chrome
3. Settings >> Profile >> Timezones >> Turn on Automatically determine your location
4. Verify the automatic timezone is Asia/Saigon
5. Open iOS app, go to any chat participated in by the above account

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add DateTimeFormat polyfills with timezone abbreviations #31074

If no regressions arise, payment will be issued on 2024-01-18. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)
• @tienifr requires payment automatic offer (Contributor)

[NicMendonca]

everyone has been paid!

[tienifr]

@NicMendonca Hi, sorry for getting here late but it seems that I wasn't paid a reporting bonus ($50) here (the issue was from long ago when the reporting bonus still applies)

Could you help handle this? Thanks!

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[pecanoro]

@jliexpensify It seems we are missing a reporting bonus here for a while ago. Could you double-check? Nicole is OOO so she won't be able to check for a while

[jliexpensify]

I can confirm that @tienifr qualifies for a $50 payout as indicated here

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Damn, I thought that would create a new Upworks job.

[jliexpensify]

Ah, no need! I can just do a ND payment 😓

• @tienifr $50 (Reporting Bonus from ages ago)

[JmillsExpensify]

$50 approved for @tienifr

[kavimuru]

Not reproducible with this build ad hoc build on iOS #51456 (comment)