[HOLD for payment 2023-10-27] [$500] IOU Category - Search message shows 'Invalid email' when typing email address in search field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27459

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any workspace chat
3. Go to + > Request money > Manual
4. Enter an amount
5. Click Show more > Category.
6. Enter a few letters, followed by @

Expected Result:

The message below the search field will display 'No results found'..

Actual Result:

The message below the search field displays 'invalid email' when Category search does not involve email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211688_20230923_190412.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131655c00ab293751
• Upwork Job ID: 1710313308418142208
• Last Price Increase: 2023-10-13
• Automatic offers:
• DylanDylann | Contributor | 27217343

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Category - Search message shows 'Invalid email' when typing email address in search field

What is the root cause of that problem?

App/src/libs/OptionsListUtils.js

Lines 1476 to 1485 in 5aa7f6d

	if (searchValue && !hasSelectableOptions && !hasUserToInvite) {
	if (/^\d+$/.test(searchValue) && !isValidPhone) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
	}
	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}
	if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
	return '';
	}

Let's see the logic to get header message, we are checking if the search value includes "@" we will display errorMessageInvalidEmail instead of noResultsFound

What changes do you think we should make in order to solve the problem?

In this case, we don't search email and phone number

App/src/libs/OptionsListUtils.js

Lines 1477 to 1485 in 5aa7f6d

	if (/^\d+$/.test(searchValue) && !isValidPhone) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
	}
	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}
	if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
	return '';
	}

So this logic to redandunt. We need to pass one more params called includeEmailAndPhoneNumber to getHeaderMessage function

and only apply logic to check email and phone if this param is true

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Not sure how to make a Category, asking QA - https://expensify.slack.com/archives/C9YU7BX5M/p1695681312874909

[Christinadobrzyn]

still trying to get Categories to work on my c.dobrzyn+45@expensifail.com account.

Asking if anyone else has this issue? https://expensify.slack.com/archives/C01SKUP7QR0/p1695845916425979

[DylanDylann]

@Christinadobrzyn I still can reproduce this bug on the latest main by enabling permission in the codebase. You can ping C+ team or internal engineer to help verify the bug

[DylanDylann]

@Christinadobrzyn This is an example of category issue: #28079

[DylanDylann]

@s77rt It seems @Christinadobrzyn can't access the category feature. Because you are C+ Contributor of another issue that relates to category #28517. Could you help to verify this is a bug?
Sorry, If I bothers you

[s77rt]

I can reproduce the bug

[Christinadobrzyn]

Thanks @DylanDylann! I'll reopen and assign a C+ since you can still see it's happening.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131655c00ab293751

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Category - Search message shows 'Invalid email' when typing email address in search field

What is the root cause of that problem?

To determine the email, we only use the presence of @ in the line

App/src/libs/OptionsListUtils.js

Line 1480 in 5aa7f6d

if (/@/.test(searchValue) && !isValidEmail) {

What changes do you think we should make in order to solve the problem?

But what is email?
To put it roughly

leters => @ => leters => . => leters

(Plus numbers. But I'm not sure that they can be used in every point in my scheme)

So we can use this regex /\w+@\w+\.\w+/
to check, the text looks like an email or not

and then we will check string is valid or not using isValidEmail

As a result

        if (/\w+@\w+\.\w+/.test(searchValue)) {
            if (!isValidEmail) {
                return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
            }
        }

App/src/libs/OptionsListUtils.js

Lines 1480 to 1482 in 5aa7f6d

	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}

But actually it would be great
Get several test cases
To check what we expect ))

Screen.Recording.2023-10-06.at.17.57.07.mov

What alternative solutions did you explore? (Optional)

[ChrisCates]

@ZhenjaHorbach, I'm also interested in the project.

By the way the regular expression you suggested will work for validation only if there is no punctuation in the TLD.

/\w+@\w+\.\w+/

It's better to use:

/\S+@\S+\.\S+/

This will return the whole email on a match. And not partial using the \w expression if the email has punctuation.
The regex you provided will break if the TLD has punctuation in it.

Hope this helps.

[melvin-bot]

📣 @ChrisCates! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ChrisCates]

Contributor details
Your Expensify account email: hello@chriscates.ca
Upwork Profile Link: https://www.upwork.com/freelancers/~01ed9060ff74912e35

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ZhenjaHorbach]

No, everything is good )

Plus it's just an idea )
First need to get more information)

And regular expression will be updated after final requirements

[DylanDylann]

@rushatgabhane this PR is ready for review

[rushatgabhane]

approved

[melvin-bot]

🎯 ⚡️ Woah @rushatgabhane / @DylanDylann, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @DylanDylann got assigned: 2023-10-16 10:16:13 Z
• when the PR got merged: 2023-10-18 07:08:00 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix:28078 Search message shows Invalid email when typing email addres… #29741

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @DylanDylann requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MariaHCD]

I believe we just need the BZ checklist here so we can proceed with the payments

[Christinadobrzyn]

Payouts due:

Issue Reporter: NA - reporter is Applause
Contributor: $500 + $250 speed bonus @DylanDylann (Paid through Upwork)
Contributor+: $500 + $250 speed bonus @rushatgabhane (paid manually in NewExpensify)

Eligible for 50% #urgency bonus? Y - #28078 (comment)

Upwork job is here.

@rushatgabhane could you let us know about a regression test?

[Christinadobrzyn]

nudge @rushatgabhane about a regression test, thanks!

[melvin-bot]

@MariaHCD, @rushatgabhane, @Christinadobrzyn, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[Christinadobrzyn]

Dming @rushatgabhane to see if we need a regression test

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Categories UI/UX #26501

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26501/files#r1384335093

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again N.A.

[rushatgabhane]

Created a manual request https://staging.new.expensify.com/r/8819237970145454

[Christinadobrzyn]

awesome! I think this can be closed.

[JmillsExpensify]

$750 payment approved for @rushatgabhane based on this comment.