-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-21] [$500] Focus freeze on add contact method magic code on coming back from search #28340
Comments
Triggered auto assignment to @jliexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~01ba4effd8bd80f395 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Input loses the ability to focus after going to search and coming back to input. What is the root cause of that problem?The behavior of the MagicCodeInput relies on the method What changes do you think we should make in order to solve the problem?We can add a new event listener to ScreenWrapper to listen for onFocus instead of onEntryTransitionEnd. OnFocus gets called every time the screens goes from not visible->visible regardless of the screen already being present in the navigation history or not. This would allow to call focus on the input whenever the input goes into view. This would have the MagicCodeInput restored to its expected behavior. Make use of the new App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js Lines 234 to 238 in 7d32e61
And add the code below along with unsubscribe to https://github.com/Expensify/App/blob/main/src/components/ScreenWrapper/index.js: if (this.props.onFocus) {
this.unsubscribeOnFocus = this.props.navigation.addListener('focus', () => {
this.props.onFocus();
});
} What alternative solutions did you explore? (Optional)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Focus freeze on add contact method magic code on coming back from search . What is the root cause of that problem?
Height Glitch: height_glitch.mp4What changes do you think we should make in order to solve the problem?We should add a
For the height glitch we can pass a prop to
Result:fix_demo.mp4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.In App/src/components/TextInput/BaseTextInput.js Lines 140 to 143 in 67d4a7a
we're calculating the height of the input based on After come back to 2FA page, the -> we can't interactive with the input What changes do you think we should make in order to solve the problem?
-> we need to add
we need to use setTimeout here to wait for navigation end. We already discuss this problem in this conversation Or we can use What alternative solutions did you explore? (Optional)in |
@redpanda-bit Your main solution is not working. So the issue is not about the input not just focusing after the back from the search page.
@Krishna2323 I don't understand this solution. What is defining the value of @tienifr We can use the same pattern https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979 for auto focus an input. Could you confirm it's working before #21482? Removing the |
@mollfpr yes it worked before, but we can not revert this PR. What do you think about my proposal above? Thanks |
@mollfpr It still works after applying transitionProperty Screen.Recording.2023-09-29.at.09.43.39.mov |
Thanks @tienifr The proposal from @tienifr looks good to me! For the autofocus input, we can follow the recommendation https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979 🎀 👀 🎀 C+ reviewed! |
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
Assigned @tienifr! |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
https://github.com/Expensify/App/pull/21482/files#r1367256050
I don't think we can prevent this kind of bug with the checklist since it's very specific things to check. So the regression step should be enough. [@mollfpr] Determine if we should create a regression test for this bug.
@jliexpensify Could you confirm which date payment is the correct one? |
if so, it was deployed to prod on October 14th, so payment date should be 21st. But I do see there were 2 failures - this doesn't matter right?: |
Payment Summary:
|
Probably, yes! @jliexpensify I'll request the payment in NewDot, thank you! |
Oh didn't realise you qualify for ND payments. Have adjusted above and will cancel your offer @mollfpr |
Paid and job closed! |
$500 payment approved for @mollfpr based on summary above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Focus should not freeze when we come back to add contact method magic code page from search
Actual Result:
Focus freezes when we come back to add contact method magic code page from search
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.74-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
mac.chrome.desktop.focus.freeze.on.back.from.search.magic.code.mov
Recording.98.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695744610116319
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: