[$500] IOU - Crash when editing the description of an IOU that was initially created with a description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27830

Action Performed:

1. Open a New Expensify app
2. Log in with any account
3. Navigate to any conversation
4. Create any IOU with a description
5. Navigate to the details of the created IOU
6. Edit or add a description

Expected Result:

You should be able to edit the description again or as many times as you need without a crash

Actual Result:

The app crashes when attempting to edit the IOU description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• Windows / Chrome
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6218603_1695963462320.Recording__375.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a56b914ca5e471d
• Upwork Job ID: 1713998814284345344
• Last Price Increase: 2023-10-23

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[strepanier03]

Newdot went down for me in the middle of testing this. Will move on and circle back.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

I cannot recreate this.

[strepanier03]

[strepanier03]

@lanitochka17 - Can you still repro this? I haven't been able to at all and am thinking of closing it.

[lanitochka17]

@strepanier03 Hello Errors do not appear, but now there is a crash, change description

Recording.178.mp4

[strepanier03]

Thanks for the heads up @lanitochka17 - I'll test again.

[melvin-bot]

@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

I can recreate this with the crash on staging so I'll update the OP comment.

2023-10-16_12-16-30.mp4

[melvin-bot]

@strepanier03 @aimane-chnaif this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[aimane-chnaif]

@wlegolas can you test again on latest main?

[wlegolas]

@wlegolas can you test again on latest main?

Sure, I'll test and bring the result.

[wlegolas]

Hi @aimane-chnaif

Unfortunately, the error still occurs using the latest main version v1.3.92-0.

error-when-editing-money-request-description.mp4

[strepanier03]

I'm going to switch this back to External.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[wlegolas]

Proposal

Updated

[pradeepmdk]

@wlegolas I am not able to reproduce this on the latest main. are you?

[aimane-chnaif]

@wlegolas if you have constant repro step, do you mind sharing your test account with me?
My transaction comment is always string from backend so hard to reproduce. Btw, I have ever noticed console error because of numeric comment, but not recently.

[wlegolas]

Hi @aimane-chnaif and @pradeepmdk

This issue was fixed yesterday through this PR #30526.

[aimane-chnaif]

@wlegolas I am even not able to reproduce without #30526 fix

[aimane-chnaif]

@strepanier03 we can close this as fixed

[wlegolas]

Hi @aimane-chnaif I think the problem is related to the old money requests, when I create a new one, the comment value is of type string.

When I'm using an old money request I can see that the comment is a number, but with the fix #30526 the issue is not happening.

[aimane-chnaif]

ok, so I am sure it's fixed in backend as well, which made fix of #30526 was also workaround & unnecessary

[strepanier03]

Per this I am closing as fixed.