[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Distance - The error message for "Invalid amount" appear when the correct amount is selected

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the "+" button.
2. Navigate to Request money > Distance.
3. Select start and finish points and click on "Next."
4. Choose the expense room and click on "Request."
5. Notice the display of the "Invalid amount" error message even when the correct amount is selected.

Expected Result:

The error message for "Invalid amount" should not appear when the correct amount is selected

Actual Result:

Incorrectly displays an "Invalid amount" error message even when the amount is entered correctly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - app is down
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20231003040531.mp4

screen-recording-2023-10-03-at-34459-am_kNSmoKGy.mp4

Screen.Recording.2023-10-03.at.4.03.08.AM.mov

Screen.Recording.2023-10-03.at.3.57.38.AM.mov

Screen.Recording.2023-10-03.at.3.55.18.AM.mov

Recording.4829.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696287219855449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dff800754c90792c
• Upwork Job ID: 1709206143119994880
• Last Price Increase: 2023-10-03

[kbecciv]

Linking PR #28685

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dff800754c90792c

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[mountiny]

This is fixed, updating to handle the payment for the reporter

[mountiny]

@alexpensify The only payment due is $50 to @ayazhussain79

[aldo-expensify]

Prepared PR for: #28721 (comment)

#28734

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: pass decimals parameter to validateAmount in MoneyRequestConfirmationList #28685

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix precision error when creating distance request #28734

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aldo-expensify] Determine if we should create a regression test for this bug.
• [@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Not overdue, the payment date is set for tomorrow

[alexpensify]

To prepare for payment - @ayazhussain79 can you please request to be part of this Upwork job? It will help ensure that I assign the complete process to the right account. Thanks!

https://www.upwork.com/jobs/~01dff800754c90792c

[ayazhussain79]

@alexpensify applied on upwork

[alexpensify]

Done -- I've paid @ayazhussain79 via Upwork, thanks!

[alexpensify]

@ayazhussain79 - I'm not sure what happened in Upwork but I just noticed that the payment was not sent. It's all complete now and I see the Paid flag.

[ayazhussain79]

@alexpensify np Thank you