[HOLD for payment 2023-12-18] Web - Camera border color is different

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > profile
2. Check the border color around the camera icon

Expected Result:

Border color should be match with background

Actual Result:

Border color is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694753216621329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b
• Upwork Job ID: 1709571217501925376
• Last Price Increase: 2023-10-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

camera border color is different

What is the root cause of that problem?

We are using wrong borderColor

What changes do you think we should make in order to solve the problem?

Change borderColor from textReversed to componentBG and also we can remove the unwanted prop color

App/src/styles/styles.js

Lines 2685 to 2695 in db4d85b

	smallEditIcon: {
	alignItems: 'center',
	backgroundColor: theme.buttonHoveredBG,
	borderColor: theme.textReversed,
	borderRadius: 14,
	borderWidth: 3,
	color: theme.textReversed,
	height: 28,
	width: 28,
	justifyContent: 'center',
	},

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border color is different

What is the root cause of that problem?

We are using incorrect borderColor here,

App/src/styles/styles.js

Line 2703 in 96c6c51

borderColor: theme.textReversed,

What changes do you think we should make in order to solve the problem?

Replace theme.textReversed with theme.appBG

smallEditIcon: {
        alignItems: 'center',
        backgroundColor: theme.buttonHoveredBG,
        borderColor: theme.appBG,
        borderRadius: 14,
        borderWidth: 3,
        color: theme.textReversed,
        height: 28,
        width: 28,
        justifyContent: 'center',
    }

What alternative solutions did you explore? (Optional)

NA

Result:

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

[sobitneupane]

Sorry for the delay.

I will try to review the proposals before EOD tomorrow (NPT).

[sobitneupane]

@anmurali Should we confirm with the Design team whether this is a bug or intended design?

Actual Result	Expected Result

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[teneeto]

@anmurali Should we confirm with the Design team whether this is a bug or intended design?

Actual Result Expected Result

@anmurali @sobitneupane Any updates ?

[PiyushChandra17]

@anmurali @sobitneupane Can you please review my proposal, I think theme.appBG should be the way to go because we just need to be consistent throughout the app (darkAppBackground). Thanks!

[melvin-bot]

@anmurali, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@anmurali, @sobitneupane Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@anmurali, @sobitneupane Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@anmurali, @sobitneupane 12 days overdue now... This issue's end is nigh!

[anmurali]

Asked here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Finalize Light Mode / Dark Mode (with new primitives) #32512

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[grgia]

@anmurali all that's required to close this one out is $500 C+ review payment to @sobitneupane

[melvin-bot]

@anmurali, @sobitneupane, @grgia Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali, @sobitneupane, @grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@anmurali, @sobitneupane, @grgia 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@anmurali, @sobitneupane, @grgia 10 days overdue. I'm getting more depressed than Marvin.

[gadhiyamanan]

@grgia reporting bonus is pending , can you reopen the issue ...

[JmillsExpensify]

$500 approved for @sobitneupane based on this comment. Also re-opening for BZ to settle the comment above.

[anmurali]

Offer for @mananjadhav for reporting bonus
@mananjadhav can you please update here when you accept? I am adding a BZ backup as I will be OOO

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mananjadhav]

@anmurali The offer needs to be sent to @gadhiyamanan.

[MitchExpensify]

The offer is indeed for @gadhiyamanan, thanks for the heads up though @mananjadhav! Please let me know when you have accepted @gadhiyamanan 🙇

[gadhiyamanan]

@MitchExpensify offer accepted, thanks!

[MitchExpensify]

Paid! Thanks