[HOLD for payment 2023-10-18] [$500] Two "Flag as offensive" list opens

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. hover on message and right click
3. select Flag as offensive
4. click on back button

Expected Result:

should hide Flag as offensive list

Actual Result:

Flag as offensive list appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-04.at.2.24.22.PM.1.mov

Screen.Recording.2023-10-04.at.2.17.48.PM.1.mov

Recording.472.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696409294638669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfd52163177c5b7e
• Upwork Job ID: 1709673665006915584
• Last Price Increase: 2023-10-04
• Automatic offers:
• gadhiyamanan | Contributor | 27048435
• gadhiyamanan | Reporter | 27048436

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfd52163177c5b7e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[m-natarajan]

Proposal by @gadhiyamanan

Please re-state the problem that we are trying to solve in this issue.

two Flag as offensive list open

What is the root cause of that problem?

We are navigate to flag comment two times here and here

What changes do you think we should make in order to solve the problem?

add return after hideContextMenu and navigate to flag comment

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 374 to 376 in 56eda28

	if (closePopover) {
	hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)));
	}

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on context menu item Flag as offensive opens a popover but it is not getting closed.

What is the root cause of that problem?

There is redundant call to navigate method in onPress event of the menu item

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 373 to 379 in 6d86d5a

	onPress: (closePopover, {reportID, reportAction}) => {
	if (closePopover) {
	hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)));
	}
	Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID));
	},

What changes do you think we should make in order to solve the problem?

We need to confirm why 2 times above callback is being called and if second callback is not necessary then remove it

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 378 in 6d86d5a

Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID));

or simply returning after hideContextMenu call will also fix the issue

What alternative solutions did you explore? (Optional)

N/A

[maxconnectAbhi]


# Proposal

Please re-state the problem that we are trying to solve in this issue

"Flag as offensive" list modal opens two times

What is the root cause of that problem?

Following callback is the root cause

onPress: (closePopover, {reportID, reportAction}) => { 
     if (closePopover) { 
         hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID))); 
     } 
  
     Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)); 
 }, 

What changes do you think we should make in order to solve the problem?

In above callback we need to remove one Navigation call

What alternative solutions did you explore? (Optional)

NA

[burczu]

I've reviewed all the proposals and all of them define the root cause correctly but I think the best solution (and the first one) is the one from @gadhiyamanan - I believe here the return statement is just missing in the if block - we can compare it with similar implementations of onPress method for other context menu items in the ContextMenuActions.js - they are similar so I believe calling navigate twice is intended.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gadhiyamanan]

@m-natarajan is from QA team and he posted solution from slack

cc: @burczu @francoisl

[burczu]

@gadhiyamanan Ahh... sorry, I didn't notice it! Updated!

[ayazalavi]

@burczu i think the person who posted issue should not be putting proposal. Otherwise there will be no margin for others.

[maxconnectAbhi]

They Both seems to be friends 😀

[francoisl]

Works for me, @gadhiyamanan let's go with your solution.

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[gadhiyamanan]

@burczu PR is ready for review

[burczu]

@burczu i think the person who posted issue should not be putting proposal. Otherwise there will be no margin for others.

@ayazalavi This is quite common situation when some contributor posts they proposal directly in the Slack thread and then when QA engineer creates an issue on GH they just add the proposal along. You check it here: https://expensify.slack.com/archives/C049HHMV9SM/p1696409294638669

[melvin-bot]

🎯 ⚡️ Woah @burczu / @gadhiyamanan, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @gadhiyamanan got assigned: 2023-10-06 00:12:53 Z
• when the PR got merged: 2023-10-06 20:37:30 UTC

On to the next one 🚀

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix opens two "Flag as offensive" list #28978

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @gadhiyamanan requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: No regression - it was just done this way from the beginning.
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payments complete and BZ checklist done, we're all done here, thanks everyone.