[HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/ in Chrome or Android App
2. Click the Green '+' Icon in the LHN
3. Choose "Request Money"
4. Enter an Amount
5. Tap Next
6. Choose a Recipient
7. Tap "Request"
8. Tap on the IOU transaction to open IOU detail page
9. Enter a description with numbers only (ex 444) and save it
10. Tap the amount and change it
11. Tap the Description again

Expected Result:

When user changes Amount and taps Description, the site must not crash

Actual Result:

When user changes Amount and tap Description, the site crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6233354_1697045658598.77cras.mp4

logs.txt

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01651ddb346bd06cdb
• Upwork Job ID: 1716876781919485952
• Last Price Increase: 2023-10-24

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[puneetlath]

I just attempted this on staging and it didn't crash.

[Christinadobrzyn]

I can't get a crash either... asking QA to test again - https://expensify.slack.com/archives/C9YU7BX5M/p1697064585308679

[izarutskaya]

Hi @Christinadobrzyn, we can't repro this crash today.
Version Number: 1.3.83-1

Screen.Recording.20231012.094822.Chrome.mp4

Record.2023-10-12-10-13-00.mp4

[puneetlath]

Seems fixed!

[lanitochka17]

Issue reproducible on Build 1.3.84-0
Windows10/Chrome

Recording.225.mp4

[Christinadobrzyn]

Thanks @lanitochka17 can you update to version v1.3.85-4 and let us know if you still see the crash?

[lanitochka17]

Issue reproducible on build 1.3.86-3
Windows10/Chrome (incognito)
Black screen is displayed

Recording.255.mp4

[Christinadobrzyn]

oh! @lanitochka17 you're seeing this only on Windows and not a Mac? I don't think we're deploying any fixes for Windows unless it's a major problem - which I don't think this is?

Can you test on a Mac with Chrome/iOS/Android and let me know if you see this issue?

I just tested on Mac Chrome v1.3.86-3 - incognito and can't reproduce.

[lanitochka17]

@Christinadobrzyn Hello

I cannot repro in Iphone 14 Pro Max/ios17

ios.123.mp4

Issue reproducible on MAC Ventura13.5/Chrome when pressed again

2023-10-18.5.11.18.PM.mov

Issue reproducible on Samsung Galaxy A50/Android11

0-02-01-02c1de3542631b475df883b5f3fcd8baecc3bee195260f50acf00be02db4ed60_d738c9651ec25c63.mp4

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@puneetlath @burczu @Christinadobrzyn this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[puneetlath]

@Christinadobrzyn yes, I agree that we should fix this if it is reproducible. We definitely want to fix it if it causes a crash.

[burczu]

Just checked the proposal from @Jenemark and I think it identifies the root cause correctly. The proposed solution to always cast the description to string in the TransactionUtils.ts file makes sense to me, so I think we could proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• description/comment to string #30526

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @Jenemark requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Payment is upcoming. Here's what I understand:

Issue Reporter: NA - Applause Team
Contributor: $500 @burczu (contractor so not paid through Upwork/New Expensify)
Contributor+: $500 @Jenemark (Paid through Upwork)

Eligible for 50% #urgency bonus? UPDATED: No - the PR was created Oct 27 which is after our Oct 24th announcement about removing speed bonuses

Upwork job is here.

Let me know if any of this needs to change and a regression test when you have a moment @burczu

[Christinadobrzyn]

@Jenemark can you accept my Upwork offer? Thanks for submitting the proposal in Upwork!
@burczu can you let us know about a regression test?

[Jenemark]

@Christinadobrzyn I accepted it on upwork, thank you :-)

[Christinadobrzyn]

Awesome! Thanks @Jenemark - I paid you in Upwork.

@burczu can you let us know about a regression test?

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:

I don't think it's a regression - this was done like this from the beginning.

• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

n/a

• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

n/a

• [@burczu] Determine if we should create a regression test for this bug.

I don't think we need to add regression test here - this is quite uncommon case, so I think not very impactful. Also the test would have quite a lot of steps.

• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

thanks @burczu!

I think this is good to close, please let me know if I'm missing anything!