Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money #29376

Closed
5 of 6 tasks
izarutskaya opened this issue Oct 11, 2023 · 53 comments
Closed
5 of 6 tasks

[$500] mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money #29376

izarutskaya opened this issue Oct 11, 2023 · 53 comments
Assignees
@JmillsExpensify @strepanier03 @teneeto @MonilBhavsar @Santhosh-Sellavel
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Oct 11, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.81-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. Go to https://staging.new.expensify.com/

  2. Tap on any 1:1 report

  3. Tap plus icon and select request money

  4. Enter amount and complete the request flow

  5. Tap on IOU request created

  6. Tap on header from link

  7. Note the green line above IOU request created

  8. Navigate back to LHN

  9. Tap any group chat

  10. Tap plus icon and select split bill

  11. Enter an amount and complete split money

  12. Tap on split money transaction

  13. Navigate back to split money created page

Expected Result:

A green line is shown on creating request money in DM but not shown while creating split money in group page and there should not be this inconsistent behaviour.

Actual Result:

A green line is shown on creating request money in DM but not shown while creating split money in group page inconsistently.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Bug6233465_1697050623088.g.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dd10227ee3f8eac1
  • Upwork Job ID: 1712197891396800512
  • Last Price Increase: 2023-11-08
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 11, 2023
@melvin-bot melvin-bot bot changed the title mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money [$500] mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dd10227ee3f8eac1

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023 •
edited by strepanier03
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@lanitochka17 lanitochka17 mentioned this issue Oct 11, 2023
Closed
6 tasks
@teneeto
Copy link
Contributor

teneeto commented Oct 12, 2023

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

@mountiny
Copy link
Contributor

@gedu @MonilBhavsar this is related to the unread marker, would you want to take care of this

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($500)

@mountiny mountiny changed the title [$500] mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money Oct 12, 2023
@MonilBhavsar
Copy link
Contributor

Thanks! Following this and looking

@teneeto
Copy link
Contributor

teneeto commented Oct 13, 2023

Hi @MonilBhavsar, are you looking into this? or just following the progress 😉

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@strepanier03, @teneeto, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

Finished testing, sorry for the delay on that.

I'll let @MonilBhavsar weigh in, I'm not sure the plan there.

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@teneeto
Copy link
Contributor

teneeto commented Oct 17, 2023

I'll drop a proposal on this, hopefully today

@MonilBhavsar
Copy link
Contributor

Teeneto sorry for confusion, If you have proposal, please share. Happy to manage the issue

@MonilBhavsar MonilBhavsar self-assigned this Oct 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@MonilBhavsar
Copy link
Contributor

Waiting for proposals here

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2023
@teneeto
Copy link
Contributor

teneeto commented Nov 15, 2023

Hi @MonilBhavsar, just a warm follow-up here. 😉

@MonilBhavsar
Copy link
Contributor

We discussed approach internally and I hope to get this live by early next week

@MonilBhavsar MonilBhavsar added the Reviewing Has a PR in review label Nov 17, 2023
@MonilBhavsar
Copy link
Contributor

Adding Reviewing label as we need two PR's to be deployed in order

@teneeto
Copy link
Contributor

teneeto commented Nov 20, 2023

internally

Ayye, nice... Although the link didn't work for me.

@MonilBhavsar MonilBhavsar mentioned this issue Nov 21, 2023
Closed
6 tasks
@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@MonilBhavsar MonilBhavsar mentioned this issue Nov 22, 2023
Closed
20 tasks
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

@strepanier03, @teneeto, @MonilBhavsar, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar
Copy link
Contributor

PR should be on staging tonight and we'll be able to test this proposal #29376 (comment)

@MonilBhavsar MonilBhavsar removed the Reviewing Has a PR in review label Nov 28, 2023
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Nov 28, 2023 •
edited
Loading

@teneeto On staging app, for money preview actions, you should be able to view childLastActorAccountID property in Onyx DB. You can test this proposal now #29376 (comment)

@teneeto
Copy link
Contributor

teneeto commented Nov 28, 2023

Nice let me check and try it out, nice work @MonilBhavsar

@MonilBhavsar
Copy link
Contributor

Awesome, thanks!! 😄 Let me know how it goes and If I could help

@teneeto teneeto mentioned this issue Nov 29, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 25, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 25, 2023

This issue has not been updated in over 15 days. @strepanier03, @teneeto, @MonilBhavsar, @Santhosh-Sellavel eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 25, 2023
@MonilBhavsar
Copy link
Contributor

We can close this. @Santhosh-Sellavel needs to be paid for C+ review. Are you paid through newDot?

@Santhosh-Sellavel
Copy link
Collaborator

@strepanier03 Can I get a payment summary message?

@strepanier03
Copy link
Contributor

Sure thing @Santhosh-Sellavel, sorry for the hold up. in the future if these can be switched to Daily when payment is needed that would help because with it on Monthly I'm not likely to look at this until it goes overdue.

@strepanier03
Copy link
Contributor

Payment Summary:

@strepanier03
Copy link
Contributor

Closing now. Thanks @Santhosh-Sellavel

@Santhosh-Sellavel
Copy link
Collaborator

Requested on ND

@JmillsExpensify
Copy link

$50o approved for @Santhosh-Sellavel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

@strepanier03 strepanier03

@teneeto teneeto

@MonilBhavsar MonilBhavsar

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@JmillsExpensify @strepanier03 @teneeto @MonilBhavsar @mountiny @Santhosh-Sellavel @izarutskaya