[WAITING ON CHECKLIST] Send money - Amount sent is copied as NaN in send money report page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Send money
3. Send money to any user
4. Click on the IOU preview to open report page
5. Click on the avatar on the header
6. Right click on the IOU card and select Copy to clipboard
7. Paste it in the composer

Expected Result:

The amount sent is copied correctly

Actual Result:

The amount sent is copied as NaN

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234471_1697117342855.20231012_194342.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b326fbae821e5272
• Upwork Job ID: 1712524952357588992
• Last Price Increase: 2023-10-12
• Automatic offers:
• cubuspl42 | Reviewer | 27446145
• saranshbalyan-1234 | Contributor | 27446146

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b326fbae821e5272

[mountiny]

I dont think this has to be a deploy blocker

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot]

Upwork job price has been updated to $125

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount sent is copied as NaN in send money report page

What is the root cause of that problem?

We are trying to deconstruct amount from originalMessage directly in the reportAction and it doesnt exist in this object here

App/src/libs/ReportUtils.js

Line 3792 in 6c7ee53

const {amount, currency, IOUReportID} = originalMessage;

but these details exist in IOUDetails object in orignalMessage object.

What changes do you think we should make in order to solve the problem?

Just change the above code to this

     const {amount, currency, IOUReportID} = originalMessage.IOUDetails;

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@cubuspl42, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Bump @cubuspl42 for reviews, cheers!

[cubuspl42]

We should go with @saranshbalyan-1234, I checked the code, and there's nothing much to discuss here

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[saranshbalyan-1234]

Hi, just wanted to know how the price changes for a job. It seems it was 500 previously.

[cubuspl42]

@saranshbalyan-1234 It was changed before your proposal was posted:

#29441 (comment)

But prices can be adjusted at Expensify's discretion, in general.

[saranshbalyan-1234]

Ohhh, thank you @cubuspl42 for respoding

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jliexpensify]

@saranshbalyan-1234 @cubuspl42 do we have a regression?

[cubuspl42]

@jliexpensify It looks like we do. I'm catching up.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix clipboard in report utils #30640

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @saranshbalyan-1234 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

fyi: #30796 (comment)

[jliexpensify]

Thanks Greg - so to summarise: no penalty for regression here?

If so, Payment Summary:

• Contributor: @saranshbalyan-1234 $125
• C+: @cubuspl42 $125

Upworks job here

Will pay today

[jliexpensify]

Paid and job closed. @cubuspl42 please complete the checklist!

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • Fix Copying Sent Money Report Action text copies a wrong text #27889
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • https://github.com/Expensify/App/pull/27889/files#r1392452654
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • Up to the QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Press to the "+" button, then select "Send money"
  • Proceed to send money to any user
  • Click on the IOU preview to access the report page
  • Click on the avatar located in the header
  • Right-click on the IOU card and choose "Copy to clipboard"
  • Paste the copied content into the composer
  • Verify that the pasted text correctly displays the user's name and amount