[HOLD for payment 2023-12-07] [$500] Go back from Flag as offensive doesn't display correct report page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697654423349679

Action Performed:

1. Go to any public room report exam
2. Hold touch on any chat message select "Flag as offensive"
3. Reload page exam
4. Select back button

Expected Result:

App should display report from Flag as offensive

Actual Result:

App doesn't display report from Flag as offensive

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

az_recorder_20231019_004916.mp4

iOS: Native

iOS: mWeb Safari

RPReplay_Final1697654319.MP4

MacOS: Chrome / Safari

flag-as-offensive-chrome.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bff2f94a7065c212
• Upwork Job ID: 1715445279961526272
• Last Price Increase: 2023-10-20
• Automatic offers:
• suneox | Contributor | 27349484

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bff2f94a7065c212

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[m-natarajan]

Proposal from @suneox

Please re-state the problem that we are trying to solve in this issue.

Go back from Flag as offensive doesn’t display correct report page

What is the root cause of that problem?

In the HeaderWithBackButton of the FlagCommentPage we dont specify a route for the back action

What changes do you think we should make in order to solve the problem?

We should handle onBackButtonPress go to current report from HeaderWithBackButton

    <HeaderWithBackButton
        title={props.translate(‘reportActionContextMenu.flagAsOffensive’)}
        onBackButtonPress={() => Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID))}
    />

What alternative solutions did you explore? (Optional)

[mananjadhav]

@suneox's proposal seems good. quick straight forward fix.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[iwiznia]

@mananjadhav I am confused, I see no proposal from @suneox... did you mean to say @m-natarajan and pick this proposal?

[mananjadhav]

@iwiznia Sorry for the confusion, I should've linked the comment.

@m-natarajan is from Applause and @suneox is the reporter who posted the solution on slack.

[mananjadhav]

@suneox Can you please post a comment with your proposal? So that it can be assigned.

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Go back from Flag as offensive doesn’t display correct report page

What is the root cause of that problem?

In the HeaderWithBackButton of the FlagCommentPage we dont specify a route for the back action

What changes do you think we should make in order to solve the problem?

We should handle onBackButtonPress go to current report from HeaderWithBackButton

   <HeaderWithBackButton
      title={props.translate(‘reportActionContextMenu.flagAsOffensive’)}
      onBackButtonPress={() => {
          const topMostReportID = Navigation.getTopmostReportId();
          if (topMostReportID) {
              Navigation.goBack(ROUTES.HOME);
              return;
          }
          Navigation.goBack();
          Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID));
      }}
   />

this pattern has been applied at ReportDetailPage to avoid back multiple times keep navigation history

What alternative solutions did you explore? (Optional)

If we need to keep the navigation history just update it to

    <HeaderWithBackButton
        title={props.translate(‘reportActionContextMenu.flagAsOffensive’)}
        onBackButtonPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID))}
    />

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[suneox]

Hi @mananjadhav the PR is ready to review

[mananjadhav]

Discussing the last comment change here. @suneox has added the following change.

Browser.isMobile() ? () => Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID)) : undefined

I don't think it's a good idea to push a platform specific check on back button press. I checked further in the code and I don't think we're doing this. @iwiznia what do you think about this?

I did another quick test (which I should've done earlier) for the profile view, it looks like we have the same behavior. So I want to go ask @Christinadobrzyn and @iwiznia, do we want to fix this across the app for other routes as well? I personally think we shouldn't as it is about fresh load of the page.

[iwiznia]

Yeah, sounds off. @suneox can you explain the problem that prompted you to add that code?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix go back from flag comment page to report #30289

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @suneox requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/344490

[Christinadobrzyn]

prepping for payment

Payouts due:

Issue Reporter: $50 @suneox (Paid in Upwork)
Contributor: $500 @suneox (Paid in Upwork)
Contributor+: $500 @mananjadhav (in NewExpensify)

Eligible for 50% #urgency bonus? N - PR created Oct 24th and merged Nov 28th

Upwork job is here.

@mananjadhav should there be a regression test?

[mananjadhav]

Yeah I think it's best we add a regression test. We've updated the back button logic and also added some calls to Navigation. QA steps from the PR body looks fine to me.

There is no offending PR, because I think we didn't consider this case.

[mananjadhav]

I've raised my request on NewDot.

[suneox]

Hi @mananjadhav
Based on the code change only affect 2 pages FlagCommentPage and ReportDetailsPage by props shouldNavigateToTopMostReport so I would like to know the scope of this regression test, Thank you

[Christinadobrzyn]

just checking @suneox @mananjadhav is there a regression from this?

[suneox]

Base on PR I think no regression

[mananjadhav]

No regression here @Christinadobrzyn

[Christinadobrzyn]

Awesome! let me know if this is ready to be closed!

[mananjadhav]

@Christinadobrzyn once it is paid out and the regression test is added we can close it.

[Christinadobrzyn]

Oh gosh, I'm sorry I thought I paid this yesterday! Sorry to keep you waiting, paying now!

[Christinadobrzyn]

Paid @suneox through Upwork based on this payment summary

Gonna close this out!

[suneox]

Thank @Christinadobrzyn and @mananjadhav I have received payment

[JmillsExpensify]

$500 payment approved for @mananjadhav based on this comment.