-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-28] Wallet - After tapping on the debit card number field, an error message appears #30703
Comments
Triggered auto assignment to @JmillsExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @tgolen ( |
@lanitochka17 I am cherry-picking the revert of the offending PR to staging now. Can you please retest this once it is deployed there and see if the deployblocker is resolved? |
@tgolen sure we will retest. |
Ready for retest please @kavimuru 🙏 |
@Beamanator Our team validating. Bug is not reproducible in all the platforms but iOS. iOS build (1.3.94-1) is not available yet. |
Can someone please assign this issue to me as I reviewed the PR? Thanks! |
I can confirm this is fixed on iOS build 1.3.94-2! 👍 |
@JmillsExpensify, @tgolen, @allroundexperts Huh... This is 4 days overdue. Who can take care of this? |
1 similar comment
@JmillsExpensify, @tgolen, @allroundexperts Huh... This is 4 days overdue. Who can take care of this? |
@allroundexperts do you mind kicking off the BZ checklist as well? |
In addition, I'd like confirmation as to whether this issue should be subject to a regression penalty? |
Regression Test
Verify that no error message appears after tapping on the debit card number field. Do we 👍 or 👎 ? |
Hmm, I'm starting to think that this might not be needed in TestRail. @tgolen can I get a second opinion? |
In the meantime, payment summary:
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I agree it's a very low-value regression. If there is already an existing regression test for adding a debit card, maybe this could be just one additional verification that the testers verify. If there is no existing regression test, then we probably don't need to add anything. |
@JmillsExpensify @allroundexperts Can we see about getting this one closed out? Looks like there is a final checklist waiting on you. |
@allroundexperts mind completing the BZ checklist? Once we get that I get can ahead and close and you can request payment in NewDot. |
@JmillsExpensify I've already added the regression test above. Rest of the checklist is not applicable here since this was just a revert of a refactor we previously did. |
Perfect, thanks for confirming. Regression test created |
$500 payment approved for @allroundexperts based on this comment. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
**Version Number:**1.3.94.0
**Reproducible in staging?:**Y
**Reproducible in production?:**N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:
Issue found when executing PR #29983
Action Performed:
Expected Result:
No error message appears after tapping on the debit card number field
Actual Result:
After tapping on the debit card number field, an error message appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6259476_1698848724874.Screen_Recording_20231101_095251_New_Expensify__1_.mp4
Production:
Screen_Recording_20231101_095251_New.Expensify.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: