Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Settings - Sign out option not visible in smaller size devices #3072

Closed
kavimuru opened this issue May 21, 2021 · 12 comments · Fixed by #3127
Closed

mWeb - Settings - Sign out option not visible in smaller size devices #3072

kavimuru opened this issue May 21, 2021 · 12 comments · Fixed by #3127
Assignees
Labels
Daily KSv2

Comments

@kavimuru
Copy link

kavimuru commented May 21, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Sign out button is visible

Actual Result:

Sign out button isn't visible

Action Performed:

  1. Go to https://staging.expensify.cash
  2. Log in with any account
  3. Go to Setting
  4. Try to Log out

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.51-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Issue reproduced in iPhone 6S and iPhone8

Bug5079506_Image_From_Ios__6_-1.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 21, 2021
@shawnborton
Copy link
Contributor

Seems like we just need to make sure this page is in a scrollView, much like we do with other pages in Settings.

@isagoico
Copy link

Issue reproducible today during KI retests

@bfitzexpensify
Copy link
Contributor

Upwork posting.

@MelvinBot
Copy link

Triggered auto assignment to @johnmlee101 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aliabbasmalik8
Copy link
Contributor

aliabbasmalik8 commented May 24, 2021

PROPOSAL

We can fix this by removing pointerEvents="box-none" at this point https://github.com/Expensify/Expensify.cash/blob/9f305176681385f2aa80f43de06fc6dffa7f0b83/src/pages/settings/InitialPage.js#L112

VIDEO AFTER IMPLEMENTED SOLUTION: https://recordit.co/yfOjPUKsq3

Thanks

@HunainAnis
Copy link

HunainAnis commented May 24, 2021

Okay, I can make the sidebar scrollable to view the signout button.

@johnmlee101
Copy link
Contributor

@aliabbasmalik8 your proposal looks good.

@aliabbasmalik8
Copy link
Contributor

@aliabbasmalik8 your proposal looks good.

can I start work?

@johnmlee101
Copy link
Contributor

Let's wait for @bfitzexpensify to accept the proposal on his end

@bfitzexpensify
Copy link
Contributor

Thanks @aliabbasmalik8, hired you on Upwork! Feel free to get started on a PR.

@isagoico
Copy link

FIxed 🎉
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants