Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IS-3072] Fixed scrolling issue #3127

Merged

Conversation

aliabbasmalik8
Copy link
Contributor

@aliabbasmalik8 aliabbasmalik8 commented May 25, 2021

Details

This issue only happens on the mobile web(you can see it on small screens, for me, it reproduced on iPhone 8).

QA STEPS

  1. Login with any account
  2. Go to Setting
  3. Try to Log out
  4. Now you can scroll and see the signout button.

Fixed Issues

Fixes #3072

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

VIDEO: https://recordit.co/CxIMHWcKTe

Mobile Web

VIDEO: http://recordit.co/A2upj3b98R

Desktop

VIDEO: https://recordit.co/Czdy11R8SF

iOS

image

Android

@aliabbasmalik8 aliabbasmalik8 requested a review from a team as a code owner May 25, 2021 18:16
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team May 25, 2021 18:16
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HorusGoul HorusGoul merged commit e857bd7 into Expensify:main May 26, 2021
@isagoico
Copy link

isagoico commented May 26, 2021

@HorusGoul @aliabbasmalik8 Are there any QA tests that should be executed here?

@aliabbasmalik8
Copy link
Contributor Author

@isagoico This issue only happens on the mobile web(you can see it on small screens, I reproduced it on iPhone 8).

  1. Login with any account
  2. Go to Setting
  3. Try to Log out
  4. Now you can scroll and see the signout button.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mWeb - Settings - Sign out option not visible in smaller size devices
3 participants