[$500] Workspace - Avatar in chat header does not revert to default avatar after deleting workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.94-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Issue found when executing PR #29554

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace and add a custom avatar.
3. Go to the #announce room.
4. Go to workspace settings.
5. Delete the workspace.
   Note that

Expected Result:

The workspace avatar in all part of the app will revert to the default avatar

Actual Result:

The custom workspace avatar in LHN and chat as well as room details page is reverted to the default avatar, except the custom avatar in the room chat header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6259691_1698858724755.20231101_104908__1_.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190689335322f5021

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar in chat header does not revert to default avatar after deleting workspace

What is the root cause of that problem?

We use this memo on the outer component to prevent re-renders from parent-renders. That is the same way we used for OptionRowLHNData

App/src/pages/home/HeaderView.js

Line 274 in 3db5ff4

export default memo(

Because report prop is passed from ReportScreen, HeaderView doesn't re-render when it is changed and the avatar of announce or admin depends on the policy but in HeaderView we don't subscribe this from Onyx which means this component doesn't re-render when the workspace avatar is changed.

What changes do you think we should make in order to solve the problem?

We should subscribe policy from Onyx in HeaderView to make this component re-render when the workspace avatar is changed or the workspace is deleted.

policy: {
    key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`
},

OPTION: we can only get some necessary field of policy to make this component doesn't re-render many times. [name, avatar, pendingAction]

Because we use memo on the outer component, we should get report and personalDetails from Onyx instead of passing them from ReportScreen

What alternative solutions did you explore? (Optional)

We can pass policy from ReportScreen to HeaderView and move the memo to inside HeaderView

Result

Screen.Recording.2023-11-02.at.00.27.49.mov

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar in chat header does not revert to default avatar after deleting workspace

What is the root cause of that problem?

I think this is not relative with policy

The root cause of this problem is that we don't use memo correctly on HeaderView

App/src/pages/home/HeaderView.js

Line 274 in a31933a

export default memo(

What changes do you think we should make in order to solve the problem?

We need to correct memo here

App/src/pages/home/HeaderView.js

Line 274 in a31933a

export default memo(

export default compose(
    withWindowDimensions,
    withLocalize,
    withOnyx({
        guideCalendarLink: {
            key: ONYXKEYS.ACCOUNT,
            selector: (account) => (account && account.guideCalendarLink) || null,
            initialValue: null,
        },
        parentReport: {
            key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID || report.reportID}`,
            selector: reportWithoutHasDraftSelector,
        },
        session: {
            key: ONYXKEYS.SESSION,
        },
    }),
)(
    memo(
        HeaderView
    ),
)

What alternative solutions did you explore? (Optional)

Screen.Recording.2023-11-02.at.12.09.38.AM.mov

[MitchExpensify]

@robertKozik How do these proposals look to you?

[MitchExpensify]

Friendly bump on a review of these proposals @robertKozik 🚀

[robertKozik]

Sorry for the delay, I'll look into the proposals today 👀

[robertKozik]

@yh-0218 Your proposal looks promising. Could you check the performance of your change? I saw that this memo was added due to performance reason and I would not like to degradate this metric

[yh-0218]

hello, @robertKozik my Proposal is updated.

[dukenv0307]

@robertKozik Tested the proposal above and it doesn't work. I think we should subscribe policy from Onyx or if we move the memo to the below, we still need to pass the policy from ReportScreen, updated proposal for this case.

web1.mov

I think the memo is used from outer to prevent re-renders from parents re-renders. We can pass the reportID, parentReportID, policyID and then subscribe all data we need from Onyx.

[melvin-bot]

@MitchExpensify, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertKozik]

Sorry for delay, on it 👀

[yh-0218]

hi, @robertKozik How about my proposal?

[melvin-bot]

@MitchExpensify @robertKozik this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[robertKozik]

@yh-0218 your updated proposal doesn't work on my end. I've checked once more previous version of it, and I can encounter some unnecessary re-renders, for example when admin changed the default currency of the workspace. This info is not used inside HeaderView so shouldn't cause re-renders

[dukenv0307]

@robertKozik The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor HeaderView component #31671

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @dukenv0307 requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Memo HeaderView #30406
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30406/files#r1411286602
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I think there is no need for regression test
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[MitchExpensify]

Payment summary:

• $500 @dukenv0307 requires payment via Upwork

[MitchExpensify]

Created an Upwork job for payment as the old one is dust: https://www.upwork.com/jobs/~01ed8ba36b00a44817

[MitchExpensify]

Let me know when you've accepted the offer there please @dukenv0307

[melvin-bot]

@MitchExpensify, @roryabraham, @robertKozik, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Looks like we're just waiting for @dukenv0307 to accept the offer of payment so that we can close this out

[roryabraham]

Tried DMing @dukenv0307 in slack to get this closed out. I also don't appear to have access to @MitchExpensify's view in Upwork, so I can see they're hired but it's not clear to me if they've been paid yet

[roryabraham]

@MitchExpensify As payment is the last todo here, I'm making you the issue owner for K2 purposes

[dukenv0307]

Thanks @roryabraham for the ping, I've accepted the offer some time ago so we're good to proceed here

[MitchExpensify]

Sorry for the delay! Paid and contract ended