[HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] Chat - Concierge Avatar is not centered

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to ND
2. Log in with any account
3. Select Concierge
4. Click on avatar

Expected Result:

Avatars is centered

Actual Result:

Avatars is not centered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269292_1699481763554.Recording__5288.mp4

Production

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

Avatars is not centered

Root Cause

We didnt added alignItems: 'center', in attachmentCarouselContainer causing this issue.
offending PR- #30995

Changes

Add alignItems: 'center' here or here.

[ZhenjaHorbach]

regression this PR #30995

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Avatars is not centered

What is the root cause of that problem?

We center the image vertically only

What changes do you think we should make in order to solve the problem?

we can update styles and add alignItems:'center' here

App/src/components/AttachmentModal.js

Line 449 in 01759d1

<View style={[styles.flex1, styles.attachmentCarouselContainer]}>

We don't need to add styles to attachmentCarouselContainer as this will break the carousel as in the first proposition

https://github.com/Expensify/App/blob/main/src/styles/styles.ts#L2520-L2526

What alternative solutions did you explore? (Optional)

NA

[ZhenjaHorbach]

@ishpaul777
Please add a comment that your second option was added after my explanations)

[ishpaul777]

Sorry but this was already spotted by me though you were still updating your proposal as i did

[ZhenjaHorbach]

This is true
But in fact
The correct solution was proposed by me at first)

[ishpaul777]

Lets leave that too reviewer rca and offending pr was spotted already though your solution built upon that

[ZhenjaHorbach]

It makes sense ))
And our propositionswere made within a minute of each other
So I doubt that my proposition was based on yours)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[deetergp]

If putting alignItems:'center' in styles.attachmentCarouselContainer would fix this issue but introduce a regression elsewhere, the I'm inclined to go with @ZhenjaHorbach's proposal.

[garrettmknight]

I don't think this needs to stop us deploying. @deetergp you reckon?

[Beamanator]

@ZhenjaHorbach you mentioned that putting alignItems: 'center' in attachmentCarouselContainer style would cause a regression. Can you explain please? I tested briefly and haven't seen any regressions

[ZhenjaHorbach]

@Beamanator
You can upload 2 images
And open one of them )
And this bug will be reproduced

Screen.Recording.2023-11-09.at.16.00.58.mov

[Beamanator]

@ZhenjaHorbach I can reproduce, thanks!

[Beamanator]

@ZhenjaHorbach it looks like your fix works very well, can you please submit a PR quickly & test on all platforms? 🙏

[ZhenjaHorbach]

@ZhenjaHorbach it looks like your fix works very well, can you please submit a PR quickly & test on all platforms? 🙏

No problem )
I'll do this now)

[Beamanator]

@ZhenjaHorbach so sorry, it looks like we have another idea for solving the regression which would be better, mentioned by the PR author here

[ZhenjaHorbach]

@ZhenjaHorbach so sorry, it looks like we have another idea for solving the regression which would be better, mentioned by the PR author here

It's OK )

[Beamanator]

CPing fix PR

• I believe this successfully made it to staging - https://github.com/Expensify/App/actions/runs/6815566820

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Move View wrapper to AttachmentViewPdf #31130

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Move View wrapper to AttachmentViewPdf #31130

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Since we didn't implement @ZhenjaHorbach's proposal so no payments on this one.