[$1000] mWeb - Cannot open protected PDF in chat view while logged into an old account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31130

Action Performed:

Prerequisites:
Must be logged into an old account that has a conversation with some attachments (images, docs, videos, PDFs).

1. Go to staging.expensify.com
2. Log in to the account mentioned in the prerequisites
3. Tap on the plus button > add attachment
4. Select a protected PDF to upload
5. Send the attachment
6. In the chat view, tap on the PDF so it opens

Expected Result:

The protected PDF should open in all valid scenarios

Actual Result:

The protected PDF cannot be opened in chat view. Instead, when attempting to open it, another attachment previously sent in the conversation is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270671_1699576904871.ND_-protected_pdf-mweb.mp4

Bug6270671_1699577000919.Repro_with_cache_cleared_2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b4605adcde6cbc56
• Upwork Job ID: 1724067109652762624
• Last Price Increase: 2023-12-04

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

@Beamanator could it be related to #31130 ? No other PR is clearly related to attachments.

[edev123]

@marcaaron I tested locally by reverting #31130 , #30995 and #30050 but the issue is still reproducible. I'm not sure but I think this might be related to the recent react-native-web upgrade(maybe).

[melvin-bot]

📣 @edev123! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Beamanator]

Hmm I just tested on iOS: mWeb Safari, v1.3.97-6, in a chat that previously had image attachments only - and wasn't able to reproduce

• Update: tried again on a chat w/ lots more images sent, and I did reproduce in staging!

[Beamanator]

There seem to also be some weird image carousel issues in production too... On the same chat as above, but in Production, I did:

1. Uploaded a second protected PDF
2. Opened it, the carousel did open directly to that PDF
3. Scrolled left twice (first scroll just opened the other protected PDF)
4. The carousel seemed to open a random image in the middle of my many images sent in that chat
5. I scroll right once from there, and saw more images - I had to scroll way far to the right (6 times) to get back to the protected PDFs I just uploaded today

[Beamanator]

Here's a screen recording: There's a decent amount of glichyness - I'm tempted to call this NAB since there's rough stuff even in prod, what do you think @marcaaron @puneetlath ?

RPReplay_Final1699606712.MP4

[puneetlath]

I agree with that. Let's not block the deploy, but let's fix it.

[melvin-bot]

@NicMendonca, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[0xmiros]

No proposals to review

[melvin-bot]

@NicMendonca, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@NicMendonca, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@NicMendonca, @0xmiroslav Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[0xmiros]

Same

[melvin-bot]

@NicMendonca, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

@Beamanator tagging you since this issue came from this PR: #31130

Should we keep this open given no traction for over a month?

[melvin-bot]

@Beamanator, @NicMendonca, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Beamanator, @NicMendonca, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[Beamanator]

@NicMendonca sorry for the delay! do you mind trying to reproduce via the original steps? I thinkkkkk if the problem still exists we should try to get it fixed - also the issue title mentions "while logged into an old account" - do you know what that means? I don't see that mentioned in the test steps so I'm not sure if it's relevant for reproducing

I guess I reproduced almost 2 months ago (notes here) so lets try that again before moving forward

[melvin-bot]

@Beamanator, @NicMendonca, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[NicMendonca]

I am unable to reproduce:

[0xmiros]

@NicMendonca I am still able to reproduce.
Not only pdf but also image.

repro step:

1. Send 3+ attachments (either pdf or image) in any chat
2. Click on the last attachment sent
3. It shows 2nd image after glitched loading, instead of 3rd image