[$250] [HOLD for payment 2024-02-20] Implement Client-side Violations when updating money requests

[cead22]

• Design Doc
• The following should only apply to users in the violations beta
• Let's connect EditRequestPage to the POLICY, and TRANSACTION_VIOLATIONS Onyx collections so we can get
  • requiresTag, requiresCategory, hasMultipleTagLists, and isTaxTrackingEnabled from the policy, and
  • The transaction violations from Onyx
• In src/pages/EditRequestPage.js let's pass policyID to editMoneyRequest, and in there pass it to IOU.updateDistanceRequest and IOU.editMoneyRequest
• Let's update src/libs/actions/IOU.js
  • In editMoneyRequest above where we set optimisticData, call ViolationUtils.getViolationsOnyxData(transactionChanges, transactionViolations, policyRequiresTags, policyTags, policyRequiresCategories, policyCategories), and add the return value to the optimisticData
  • Similarly in updateDistanceRequest after the last call to optimisticData.push, we call ViolationUtils.getViolationsOnyxData(transactionChanges, transactionViolations, policyRequiresTags, policyTags, policyRequiresCategories, policyCategories) and push the return value to optimisticData
• We can set the value of failure data to an object like in the snippet below, where transactionViolations has the data from Onyx
• Once the request is submitted, violations will be calculated on the server in EditMoneyRequest API command and pushed down to the client, but nothing about the violations that are calculated on the client should change

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`,
    value: transactionViolations,
}

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019149143c50ac6f4d
• Upwork Job ID: 1811196753636588997
• Last Price Increase: 2024-07-11

Issue Owner

Current Issue Owner: @mkhutornyi

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[cead22]

Off hold

[cead22]

@lindboe @cdanwards @trevor-coleman can you please comment here so I can assign you?

[cdanwards]

Commenting for assignment

[trevor-coleman]

🚀

[melvin-bot]

📣 @trevor-coleman! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[trevor-coleman]

Contributor details
Your Expensify account email: trevor@infinite.red
Upwork Profile Link: N/A

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[cead22]

We prioritized client side violations when creating money request. This one comes next

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Client-side violations for money request updates #34402

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @cdanwards does not require payment (Contractor)
• @trevor-coleman requires payment (Needs manual offer from BZ)

[parasharrajat]

Looks like I was never got paid for PR review #34402. @cead22 Could you please reopen and assign a BZ to finalize the checklist?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019149143c50ac6f4d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[cead22]

@mananjadhav @mkhutornyi sorry for the auto assignment, I'm trying to trigger some other automation

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cead22]

@sonialiap can you please handle payment for @parasharrajat for the PR review, and undo this #31093 (comment), I'm guessing by closing the upwork job? Thanks

[parasharrajat]

Note the price here would be 500.

[sonialiap]

Payment summary

• @parasharrajat $500 - please request in ND

Upwork job closed

[parasharrajat]

Payment requested as per #31093 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat