[Help Wanted] [$500] Web - Workspace - Infinite spinner is shown when new account creates a Free Plan

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login to OD Expensify (with invalidated account)
2. Navigate to Settings -> Workspaces ->Group
3. Click Free plan
4. Verify new opened ND Expensify page

Expected Result:

User is redirected to NewDot -> Workspace settings page

Actual Result:

New Dot Expensify page is opened with infinite loading spinner and error shown in console

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271557_1699638639966.2023-11-10_20-37-34.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01122d03775f699254
• Upwork Job ID: 1723040449741160448
• Last Price Increase: 2023-11-24

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01122d03775f699254

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[tienifr]

Can't reproduce.

[ikevin127]

I'm able to reproduce it and it's similar to this issue.

MacOS: Firefox

Screen.Recording.2023-11-13.at.21.46.34.mov

The difference is that in this case, we don't have the desktop app installed hence this part of the code comes into play:

App/src/libs/actions/App.ts

Line 507 in 629c6de

API.makeRequestWithSideEffects('OpenOldDotLink', parameters, {}).then((response) => {

which can be observed in the Networking tab as the OpenOldDotLink api call.

Given that in the video we can see the RHN of the workspace is opened initially then closed when the OpenOldDotLink is called which sets url to:

https://new.expensify.com/transition?accountID=16019534&email=kevin.bader96+8@gmail.com&shortLivedAuthToken={token}&exitTo=workspace/new&shouldForceLogin=false&ownerEmail=&makeMeAdmin=false&openOnAdminRoom=true

which causes the infinite spinner because the transition route is not properly handled by the navigator.

The problem is that compared to the web to desktop transition issue I mentioned, this one will be pretty much impossible to test externally given a proposal because it requires access to OldDot's repo in order to test a fix locally, therefore I think this should be handled internally.

[strepanier03]

@allroundexperts - Do you agree this should be handled internally? I can update the labels if so.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[strepanier03]

Bump @allroundexperts #31195 (comment)

[melvin-bot]

@strepanier03 @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[allroundexperts]

@strepanier03 I think this should be handled internally.

[melvin-bot]

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

[strepanier03]

Got it, thanks @allroundexperts - I've moved it internal and now we wait.

[melvin-bot]

@strepanier03 @allroundexperts this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@strepanier03, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

All good Melvin, waiting for an internal team member to pick this up.

[strepanier03]

Looking for internal volunteer still.

[melvin-bot]

@strepanier03 @allroundexperts this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot]

@strepanier03, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Figured I'd give this another test and I think the issue here now is that to test this you need a private domain email as all new public email sign ups on Oldot redirect you to Newdot automatically now.

• Testing on public email = no reproduction - flow is now different
• Testing on private email = no reproduction - expected result happens

---

@allroundexperts - I can't repro this any longer and a change in the flow for public emails means you won't have an unvalidated account to test with either.

Unless you can reproduce still, I would like to close this. What do you think?

[allroundexperts]

Yes, I think we can close this @strepanier03!

[melvin-bot]

@strepanier03, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@strepanier03, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!