[$500] Task - When returning from the assignee page back to the task page, the compose focus is lost

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap on a report
3. Tap icon near compose
4. Select Assign task
5. Enter title
6. Tap next
7. Tap confirm task
8. Tap on Assignee
9. Tap app's back button and return to task page

Expected Result:

When returning from the assignee page to the task page, the compose focus should not be lost.

Actual Result:

When returning from the assignee page back to the task page, the compose focus is lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271745_1699646793693.focislostandroid.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad405e0798cfa725
• Upwork Job ID: 1723080481074606080
• Last Price Increase: 2024-01-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad405e0798cfa725

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - When returning from the assignee page back to the task page, the compose focus is lost

What is the root cause of that problem?

When the user navigates back the focus event is not called.

What changes do you think we should make in order to solve the problem?

We should use the hook useFocusEffect when using navigates back, something like:

useFocusEffect(
        useCallback(() => {
            focus(true);
            // eslint-disable-next-line react-hooks/exhaustive-deps
        }, [navigation]),
    );

Result:

useFocusEffect.test.mov

[tienifr]

This issue would be fixed via #30973.

[samilabud]

Proposal

Updated

Just in case the PR doesn't fix this (or if they want to use something like this in that PR) I've updated my proposal with an actual use of what I said.

[CortneyOfstad]

Alright, holding for #30973, as that will fix the issue

[CortneyOfstad]

PR is still open, so not overdue

[CortneyOfstad]

PR is still open

[CortneyOfstad]

Deployed to production yesterday! Adjusting title for the 7-day hold 👍

[parasharrajat]

I don't think that #30973 fixed this. @tienifr Can you please confirm?

[CortneyOfstad]

@tienifr bump on the above ^^^ Thanks!

[CortneyOfstad]

@tienifr bump please!

[tienifr]

#30973 deployed to production and indeed fixed this issue.

Screen.Recording.2023-12-20.at.16.30.58-compressed.mov

[parasharrajat]

Let me test.

[CortneyOfstad]

@parasharrajat any update on the test? Thanks!

[parasharrajat]

It's not solved on Android.

Screen.Recording.2023-12-22.at.8.39.02.PM.mov

[parasharrajat]

@CortneyOfstad If you agree, could you please reset the title?

[CortneyOfstad]

Sorry, was OoO — resetting the title now!

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $500

[CortneyOfstad]

Price is correct 👍

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

Not overdue

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[CortneyOfstad]

I also can't recreated. @kbecciv we're not able to recreate this, so going to close 👍