Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Desktop - Reload - ''Hmm... it's not here'' when reloading the desktop app #31592

Closed
1 of 6 tasks
lanitochka17 opened this issue Nov 20, 2023 · 21 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch the desktop app
  2. Press Cmd + R or click on the View menu, then select ''Reload''

Expected Result:

No errors should be encountered when reloading the app

Actual Result:

When reloading the app, a 'page not found' error is displayed
Hmm... it's not here
Oops, this page cannot be found
Go back to home page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

@
Bug6284623_1700518933812.Error_when_press_cmd__R.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc65658e91d3dd1c
  • Upwork Job ID: 1726776353641140224
  • Last Price Increase: 2023-11-21
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

Production:

Screen.Recording.2023-11-20.at.19.21.05.mov

@luacmartins
Copy link
Contributor

I can reproduce this and see the following logs. It seems like we're intentionally navigating to that page.

[info] Navigating to route - {"path":"/not-found"}

@deetergp deetergp added the External Added to denote the issue can be worked on by a contributor label Nov 21, 2023
@melvin-bot melvin-bot bot changed the title Desktop - Reload - ''Hmm... it's not here'' when reloading the desktop app [$500] Desktop - Reload - ''Hmm... it's not here'' when reloading the desktop app Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fc65658e91d3dd1c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@erquhart
Copy link
Contributor

Likely same root cause as #28495, may be a dupe.

@tienifr
Copy link
Contributor

tienifr commented Nov 21, 2023

I posted a proposal on the other issue, it will fix this one as well

@situchan
Copy link
Contributor

Not able to reproduce on main. Or does this happen only in release build?

@situchan
Copy link
Contributor

@tienifr this is deploy blocker so there must be offending PR recently merged. #28495 was open for a while.

@tienifr
Copy link
Contributor

tienifr commented Nov 21, 2023

Not able to reproduce on main. Or does this happen only in release build?

@situchan yes it's only on release build

@situchan
Copy link
Contributor

For me, this happens on android chrome as well. Still interesting that not reproducible on iOS safari.

not.found.mov

@tienifr
Copy link
Contributor

tienifr commented Nov 21, 2023

For me, this happens on android chrome as well.

@situchan Yeah it’s because your https://127.0.0.1 is not in the whitelisted prefixes as well, we can optionally add that to the prefix list for development convenience.

@situchan
Copy link
Contributor

I just reproduced this today. I have been testing with https://127.0.0.1/ so far after https integration but used to work fine.

@situchan
Copy link
Contributor

So I can conclude that @tienifr's solution is just workaround without fixing the root cause.
We should really find out the offending PR.

@s77rt
Copy link
Contributor

s77rt commented Nov 21, 2023

This may be a dupe. I think this issue existed for a while but due to another factor the bug is constantly reproducible now.

I tested this on v1.3.83-0. The bug is there but not very easy to reproduce

Screen.Recording.2023-11-21.at.6.13.29.PM.mov

@mallenexpensify
Copy link
Contributor

Been working on a similar issue for weeks that might be related. I'm also getting the 'hmm' error after every time I've updated the app the past two days.
#28495

@mallenexpensify
Copy link
Contributor

From Tim G in this internal thread, in case it's helpful:

  1. If there is a reportID in the URL, load that report. (if you do not have access to that report, you are shown "not found")
  2. Sort all reports in Onyx by their lastReadTime
  3. if openOnAdminRoom param is in the URL, then fine the first report where the chat type is policyAdmins and assign it to the variable adminReport
  4. If isFirstTimeNewExpensifyUser and there is only 1 sorted report, load that report
  5. If there is more than 1 sorted report, and there is adminReport, load the first sorted report that is not concierge
  6. If they are not in the domain rooms beta
  7. filter the sorted reports to only contain non-domain chats, workspace chats, chats with their guides
  8. If adminReport exists, load it
  9. else load the last sorted report

The bulk of that logic is here: https://github.com/Expensify/App/blob/main/src/libs/ReportUtils.js#L596-L631

@s77rt
Copy link
Contributor

s77rt commented Nov 21, 2023

@tienifr Any idea why is the initial url app://- Can we change it?

@luacmartins
Copy link
Contributor

This seems to be a dupe of #28495 and given the video @s77rt shared, it seems like a race condition that was made worse with the last deploy. I'm gonna remove the deploy blocker label since this is already happening in previous versions, just not as noticeable. We need to keep investigating and fix this though.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Nov 21, 2023
@luacmartins luacmartins added Daily KSv2 and removed Hourly KSv2 labels Nov 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@s77rt
Copy link
Contributor

s77rt commented Nov 24, 2023

@luacmartins Shouldn't we close this one?

@melvin-bot melvin-bot bot removed the Overdue label Nov 24, 2023
@luacmartins
Copy link
Contributor

Yea, we should be good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants