Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] iOS - Conversation - Green line between the first and second new messages when returning online #31617

Closed
1 of 6 tasks
izarutskaya opened this issue Nov 21, 2023 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Nov 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition: user should be signed in as account A on the main testing device and as account B on the secondary

  1. Open app
  2. As user A navigate to conversation with user B
  3. Kill the app and disable the internet
  4. From the second device send two messages as user B to user A
  5. Open app on main testing device
  6. Navigate to conversation with user B
  7. Enable the internet connection

Expected Result:

Green line should be displayed above two new messages

Actual Result:

Green line displayed between first and second messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6285237_1700558400114.RPReplay_Final1700543398.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01645ac5adbffdae76
  • Upwork Job ID: 1726929269907804160
  • Last Price Increase: 2023-11-28
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 21, 2023
@melvin-bot melvin-bot bot changed the title iOS - Conversation - Green line between the first and second new messages when returning online [$500] iOS - Conversation - Green line between the first and second new messages when returning online Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01645ac5adbffdae76

Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 21, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 21, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 21, 2023

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@izarutskaya
Copy link
Author

Not reproduce in production

IMG_1460

@situchan
Copy link
Contributor

@Julesssss the offending PR should be related to unread marker. i.e. #25935

@shubham1206agra
Copy link
Contributor

@situchan The PR is not in staging yet.

@situchan
Copy link
Contributor

@shubham1206agra it hit staging.
There was deploy automation issue recently and that's why bot didn't comment on the PR.

Screenshot 2023-11-21

@rlinoz
Copy link
Contributor

rlinoz commented Nov 21, 2023

I am removing the deploy blocker label since this doesn't seem as critical.

@rlinoz rlinoz added Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@rlinoz
Copy link
Contributor

rlinoz commented Nov 24, 2023

waiting for proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 24, 2023
@rlinoz
Copy link
Contributor

rlinoz commented Nov 27, 2023

Waiting for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@keisyrzk
Copy link
Contributor

keisyrzk commented Nov 29, 2023

Tried multiple times and in my case it is working as intended. I could not reproduce the issue.

Zrzut ekranu 2023-11-29 o 08 47 34 Zrzut ekranu 2023-11-29 o 08 48 41

Copy link

melvin-bot bot commented Nov 29, 2023

📣 @keisyrzk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Julesssss
Copy link
Contributor

@rlinoz I would retest and then just close it if its no longer reproducable

@rlinoz
Copy link
Contributor

rlinoz commented Nov 29, 2023

Confirmed it is not reproducable anymore.

Closing it.

@rlinoz rlinoz closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants