[HOLD for payment 2023-12-12] [$1000] Chat - The green line is displayed chaotically at the recipient

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/ on an Android (User B)
2. Sign into Android app (User A)
3. Send a message from User B to User A
4. In LHN of user A, the message received will be shown in bold
   5.Open the message
   6.From user B, send multiple messages to User A

Expected Result:

As user A is already in conversation page, the green line must not be shown when messages received from user B

Actual Result:

The green line is displayed chaotically at the recipient

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

0-02-01-2e738be91e9bd2bfb08384aaeeda70b5f31baf0ca1f08e3082e04e5f20babf5c_da1df15568a73bb8.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a50aa27edf905a3
• Upwork Job ID: 1703890402212745216
• Last Price Increase: 2023-11-11
• Automatic offers:
• situchan | Contributor | 27473899

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

I can't reproduce this going to reach back out to QA to see if they can confirm it's still happening and update the steps to reproduce.

Reaching out to QA https://expensify.slack.com/archives/C9YU7BX5M/p1694794909719529

[lanitochka17]

Issue reproducible on Build 1.3.70-5
SG A50/Android11
Messages were sent one after another

0-02-01-05067e16c4a0326cb255943af9391b715c4d08c5f5610e43954c19c3dc28eaaf_4140450e3cdbcb4.1.mp4

[Christinadobrzyn]

I can reproduce this... but it's not super consistent. Because of the inconsistency, I wonder if we should not fix this now and see if something else resolves it.

Using V1.3.71-2 on the Android app app Samsung Galaxy S22
Using v1.3.7 0-8 on web app Samsung

screenRecording-18-9-2023-15-54.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a50aa27edf905a3

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[Christinadobrzyn]

hey @mananjadhav can you give me your thoughts on #27456 (comment)

[Christinadobrzyn]

nudge @mananjadhav on #27456 (comment)

[mananjadhav]

I tried a few times, but I couldn't. I checked on the emulator. Does it require a physical device to check?

[Christinadobrzyn]

I was using the Chrome Website on a physical Android device (User B) and messaging the Android app through Browserstack (User A).

It's not super consistent which is always tough to troubleshoot so I don't know if we should just close this and expect it will clear up with other issues.

[melvin-bot]

@mananjadhav @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Christinadobrzyn]

I updated the OP to see if that helps @mananjadhav - can you try again to reproduce and let me know what you think is best next steps here... maybe we should close since it's difficult to reproduce.

[melvin-bot]

@mananjadhav, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@Christinadobrzyn I think you can reassign this one. I haven't been able to spend as much time as this requires.

[artus9033]

Sure thing @MonilBhavsar, then I will be waiting for information when / if #25935 enters production and prepare the PR afterwards, as you pointed above.

[MonilBhavsar]

That PR is deployed to staging and will be deployed to production tonight. It has also been checked off successfully in QA test run. I think we don't need to hold onto that. Feel free to create a PR! 🚀

[artus9033]

I see, I must've confused the last messages - perfect, I will get it done, then.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[situchan]

Potential regressions from #25935:

• [$500] iOS - Conversation - Green line between the first and second new messages when returning online #31617
• [$500] IOU - Unread marker does not appear above IOU preview when IOU is received #31621
• [Paid] [$500] Chat - Unread message green line marker remains after opening the new message #31623

[artus9033]

@MonilBhavsar, the PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix green line being displayed chaotically in chat at the recipient #31627

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @artus9033 requires payment
• @roksanaz does not require payment (Contractor)
• @situchan requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

preparing for payment

Payouts due:

Issue Reporter: NA
Contributor: $1000 @artus9033 (member of Callstack so not paid through Upwork or NewExpensify)
Contributor+: $1000 @situchan (in Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

[Christinadobrzyn]

Just checking on the payment of this because there were several people working on this.

@MonilBhavsar @artus9033 and @situchan can you confirm this payment summary is correct.

Do we have a regression test for this?

[artus9033]

@Christinadobrzyn it seems like I am listed as a paid contributor, however, I should be a contractor (member of Callstack). Could you update that please?

[situchan]

Just checking on the payment of this because there were several people working on this.

@MonilBhavsar @artus9033 and @situchan can you confirm this payment summary is correct.

Do we have a regression test for this?

Correct.

I think we already we have regression test case since reported by QA team.

[MonilBhavsar]

Yes correct! We can close this once we have issued payment to everyone

[Christinadobrzyn]

Awesome! Thanks @situchan and @MonilBhavsar - I paid @situchan based on this payment summary - #27456 (comment)

I think this is good to close but let me know if I'm missing anything!