Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BA - Error message doesn't stop displaying instantly after valid data is entered in date field #31734

Closed
6 tasks done
kbecciv opened this issue Nov 22, 2023 · 5 comments
Closed
6 tasks done
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.2.0
Reproducible in staging?: y
Reproducible in production?: not able to check production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must be logged in.

  1. Go to Settings > Workspaces > Select Workspace > Bank Account.
  2. Go trough the add bank account flow until you reach a page that you have to enter any date, like Company information or Personal Information.
  3. Trigger the enter valid data error message on the date field (select the filed but do not select any date and move to another field).
  4. Select a valid date.

Expected Result:

The error message should disappear instantly, like the other fields do.

Actual Result:

The error message doesn't stop displaying instantly after valid data is entered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287443_1700671928440.Yanj6389_1_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 22, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

Looks like this is fixed when reverting #27670

@luacmartins
Copy link
Contributor

Removing blocker label since we reverted the offending PR

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Nov 22, 2023
@kowczarz
Copy link
Contributor

I think as soon as #31612 will be fixed, this issue can disappear as well.

@kosmydel
Copy link
Contributor

As @kowczarz said, this issue is resolved by this PR and probably was not related to reverting the focus trap.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants