-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEDIUM] Expensify Cards: All card pages link to the same Expensify Card #31771
Comments
@grgia Huh... This is 4 days overdue. Who can take care of this? |
@grgia Still overdue 6 days?! Let's take care of this! |
@grgia 10 days overdue. I'm getting more depressed than Marvin. |
@grgia 12 days overdue. Walking. Toward. The. Light... |
@kevinksullivan for this issue I think the root cause is mainly the incorrect card data in the DB (i.e. multiple active cards). #33515 (comment) I don't think we can update the query to filter those out, so this might be a case where having an edge case like the current design of showing multiple cards with last four pan in newdot. Sorry for the confusion with this one! For now I think we can:
How does that sound? |
@grgia Eep! 4 days overdue now. Issues have feelings too... |
Let's hold on doing anyhting here for now and see where we land on the admin side of card management. Convo: |
sounds good holding ! |
still holding |
still on HOLD |
closing in favor of #38468 |
When a user has Multiple Physical Expensify Cards in their cardList, all menuItems open the first card. This was originally designed with the incorrect assumption that a user would have max 2 cards, a physical and virtual card.
Solution
Let's use the cardIDs of the card we're opening. We may need to discuss displaying "linked" virtual cards as part of this issue or tackle that as a separate issue.
You can see an example of this in this video -
Bug6287779_1700688218527.Recording__5509.mp4
The text was updated successfully, but these errors were encountered: