Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEDIUM] Expensify Cards: All card pages link to the same Expensify Card #31771

Closed
grgia opened this issue Nov 23, 2023 · 11 comments
Closed

[MEDIUM] Expensify Cards: All card pages link to the same Expensify Card #31771

grgia opened this issue Nov 23, 2023 · 11 comments
Assignees
Labels
ECard Wave5-free-submitters Monthly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Nov 23, 2023

When a user has Multiple Physical Expensify Cards in their cardList, all menuItems open the first card. This was originally designed with the incorrect assumption that a user would have max 2 cards, a physical and virtual card.

Solution
Let's use the cardIDs of the card we're opening. We may need to discuss displaying "linked" virtual cards as part of this issue or tackle that as a separate issue.

You can see an example of this in this video -

Bug6287779_1700688218527.Recording__5509.mp4
@grgia grgia converted this from a draft issue Nov 23, 2023
@grgia grgia self-assigned this Nov 23, 2023
@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 27, 2023
@dylanexpensify dylanexpensify added the ECard Wave5-free-submitters label Nov 30, 2023
@grgia grgia added Daily KSv2 and removed Monthly KSv2 labels Dec 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@grgia Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 28, 2023

@grgia Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia 10 days overdue. I'm getting more depressed than Marvin.

Copy link

melvin-bot bot commented Jan 2, 2024

@grgia 12 days overdue. Walking. Toward. The. Light...

@grgia
Copy link
Contributor Author

grgia commented Jan 4, 2024

@kevinksullivan for this issue I think the root cause is mainly the incorrect card data in the DB (i.e. multiple active cards). #33515 (comment)

I don't think we can update the query to filter those out, so this might be a case where having an edge case like the current design of showing multiple cards with last four pan in newdot. Sorry for the confusion with this one!

For now I think we can:

  • condense everything into one eCard slot
  • if there are multiple active physical or virtual cards, show them all on the card page for now
  • work on fixing the DB in the linked issue to clear any cards that are deactivated in marqeta and not in our DB

How does that sound?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 4, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

@grgia Eep! 4 days overdue now. Issues have feelings too...

@grgia grgia added the Reviewing Has a PR in review label Jan 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
@grgia grgia removed the Reviewing Has a PR in review label Jan 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
@kevinksullivan
Copy link
Contributor

Let's hold on doing anyhting here for now and see where we land on the admin side of card management. Convo:

https://expensify.slack.com/archives/C05DWUDHVK7/p1704927942434149?thread_ts=1704920930.824409&cid=C05DWUDHVK7

@kevinksullivan kevinksullivan changed the title [ECARD] 🐛 MEDIUM: All card pages link to the same Expensify Card [HOLD on Admin card discussions] [ECARD] 🐛 MEDIUM: All card pages link to the same Expensify Card Jan 12, 2024
@grgia
Copy link
Contributor Author

grgia commented Jan 12, 2024

sounds good holding !

@melvin-bot melvin-bot bot removed the Overdue label Jan 12, 2024
@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Jan 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@grgia
Copy link
Contributor Author

grgia commented Jan 27, 2024

still holding

@grgia grgia added the Monthly KSv2 label Jan 27, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2024
@grgia grgia removed the Weekly KSv2 label Jan 27, 2024
@greg-schroeder greg-schroeder changed the title [HOLD on Admin card discussions] [ECARD] 🐛 MEDIUM: All card pages link to the same Expensify Card [HOLD on Admin card discussions] [MEDIUM] Expensify Cards: All card pages link to the same Expensify Card Feb 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2024
@grgia
Copy link
Contributor Author

grgia commented Feb 28, 2024

still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@grgia grgia changed the title [HOLD on Admin card discussions] [MEDIUM] Expensify Cards: All card pages link to the same Expensify Card [MEDIUM] Expensify Cards: All card pages link to the same Expensify Card Apr 3, 2024
@grgia
Copy link
Contributor Author

grgia commented Apr 3, 2024

closing in favor of #38468

@grgia grgia closed this as completed Apr 3, 2024
@melvin-bot melvin-bot bot removed Overdue labels Apr 3, 2024
@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECard Wave5-free-submitters Monthly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants