Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Mock Up for Displaying Multiple ECards #37686

Closed
grgia opened this issue Mar 4, 2024 · 15 comments
Closed

Create Mock Up for Displaying Multiple ECards #37686

grgia opened this issue Mar 4, 2024 · 15 comments
Assignees
Labels

Comments

@grgia
Copy link
Contributor

grgia commented Mar 4, 2024

Coming from https://expensify.slack.com/archives/C02MW39LT9N/p1709558687888869

Related to #31771

Copy link

melvin-bot bot commented Mar 4, 2024

Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.

@grgia grgia self-assigned this Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@shawnborton
Copy link
Contributor

I plan to work on this one tomorrow! Apologies, got sidetracked with Money page and Invoice mocks today.

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 7, 2024

Thanks @shawnborton !

@shawnborton
Copy link
Contributor

Quick ideas for grouping:
CleanShot 2024-03-07 at 17 04 04@2x

I assume even if you have multiple admin-issued virtual cards with the same limit, we should still show multiple rows right? So it might be something like this:
CleanShot 2024-03-07 at 17 05 01@2x

Then I like your idea to just reuse the existing row pattern within a card view for showing multiple physical cards:
CleanShot 2024-03-07 at 17 07 12@2x

cc @Expensify/design @kevinksullivan for thoughts - happy to bring this to Slack, too!

(Figma file)

@dubielzyk-expensify
Copy link
Contributor

I'm a big fan of the first one. While I like the callout for virtual cards I think it's the text label that makes it a tad bit too overwhelming. I think that detail can be pushed to the card detail screen itself.

If we don't believe the limit is important on the card overview, we could use the badge for the virtual vs physical callout.

Have you changed the pattern here and gone above the title? I thought we normally do it below. Not against it, but just wondering the reasoning or if I'm missing a pattern we have access to.

CleanShot 2024-03-08 at 16 35 56@2x

@shawnborton
Copy link
Contributor

Have you changed the pattern here and gone above the title?

I guess I was just mirroring what I had from the previous page, but you make a good point about not changing the pattern, so I'm totally down to keep it below the title:
CleanShot 2024-03-08 at 08 49 45@2x

@shawnborton
Copy link
Contributor

Then to your point about moving the "virtual card" label inside of the card view - I like that idea too:
CleanShot 2024-03-08 at 08 53 43@2x

@dannymcclain
Copy link
Contributor

Love what's going on here—one more thought: what if instead of labeling every card we just labeled the "sections" for the physical/ virtual cards? (Or maybe even JUST the virtual ones? Right mock)

CleanShot 2024-03-08 at 08 06 03@2x

@shawnborton
Copy link
Contributor

Oh that's a solid idea too, nice - I like it!

So maybe let's hear from Kevin and Georgia on how important some of these labels/badges are and we can decide from there, but feeling pretty good about the options we have for how to display them at this point.

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 11, 2024

Started a slack convo here - https://expensify.slack.com/archives/C036QM0SLJK/p1710155978612219

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 11, 2024
Copy link

melvin-bot bot commented Mar 14, 2024

@shawnborton, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@grgia
Copy link
Contributor Author

grgia commented Mar 18, 2024

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 18, 2024

This is basically done, but I'm going to leave this issue up temporarily until I create the issue implementing this today

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@shawnborton
Copy link
Contributor

Not overdue, we're all settled on the design and Georgia will implement.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 26, 2024

Closing! We'll implement here #38468

@grgia grgia closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants