-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Mock Up for Displaying Multiple ECards #37686
Comments
Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new. |
I plan to work on this one tomorrow! Apologies, got sidetracked with Money page and Invoice mocks today. |
Thanks @shawnborton ! |
I assume even if you have multiple admin-issued virtual cards with the same limit, we should still show multiple rows right? So it might be something like this: Then I like your idea to just reuse the existing row pattern within a card view for showing multiple physical cards: cc @Expensify/design @kevinksullivan for thoughts - happy to bring this to Slack, too! |
I'm a big fan of the first one. While I like the callout for virtual cards I think it's the text label that makes it a tad bit too overwhelming. I think that detail can be pushed to the card detail screen itself. If we don't believe the limit is important on the card overview, we could use the badge for the virtual vs physical callout. Have you changed the pattern here and gone above the title? I thought we normally do it below. Not against it, but just wondering the reasoning or if I'm missing a pattern we have access to. |
Oh that's a solid idea too, nice - I like it! So maybe let's hear from Kevin and Georgia on how important some of these labels/badges are and we can decide from there, but feeling pretty good about the options we have for how to display them at this point. |
Started a slack convo here - https://expensify.slack.com/archives/C036QM0SLJK/p1710155978612219 |
@shawnborton, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Above slack link was incorrect, see here https://expensify.slack.com/archives/C036QM0SLJK/p1710760620755409?thread_ts=1710155978.612219&cid=C036QM0SLJK |
This is basically done, but I'm going to leave this issue up temporarily until I create the issue implementing this today |
Not overdue, we're all settled on the design and Georgia will implement. |
Closing! We'll implement here #38468 |
Coming from https://expensify.slack.com/archives/C02MW39LT9N/p1709558687888869
Related to #31771
The text was updated successfully, but these errors were encountered: