[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Chat - After finishing the bank account closure process, the system shows a message indicating 'Unavailable Workspace and undefined in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.3.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30582

Action Performed:

1. Go to staging.new.expensify.com
2. Create 2 accounts, one will be used as employee and second as an admin
3. Request 1:1 money as employee from the admin
4. As admin, go to the 1:1 chat and click Pay With Expensify
5. Choose to pay with Business Bank account
6. Verify you have been brought to the Bank account flow
7. Select Pay with Plaid option
8. Close the bank account flow
9. Verify you can see a new report message in the 1:1 chat which links you to the workspace chat of the new employee

Expected Result:

App shows a message indicating Workspace name

Actual Result:

After finishing the bank account closure process, the system shows a message indicating 'Unavailable Workspace and undefined in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5518.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rlinoz]

I tried replicating this in dev but it fails for other reasons.

We might have to change the optimistic data from this PR.

Here are the logs from the Applause test: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2282b24ab9fc872ffc-BOS%22)+AND+timestamp:[2023-11-24T13:20:21.198Z+TO+2023-11-24T15:20:21.198Z]&index=logs_expensify-025464

cc: @mountiny

[luacmartins]

This happens because we call buildOptimisticMovedReportAction here, which loads allReports and allPolicies to get the name, but those are not yet available in Onyx because they are only set when we make the API request here

[luacmartins]

Another issue that I'm seeing is that ownerEmail is not available in iouReport - https://github.com/Expensify/App/blob/88cb0bdd9326cfd1a8960f38b54077dba3c04cc9/src/types/onyx/Report.ts because we only have ownerAccountID, so the API request actually fails with:

2023-11-24T23:45:56.937882+00:00 expensidev2004 php-fpm: YVDoAz /api.php n75@n.com !ecash1.4.3-6! ?api? [hmmm] Throw ExpException - 93d440893453d5517c59e88f4b1c0104 ~~ message: '402 Missing field in memberData: email' exceptionMessage: 'Auth CreatePolicy returned an error' exceptionFile: '/vagrant/Web-Expensify/lib/Auth.php' exceptionLine: '124' exceptionCode: '402'

[luacmartins]

I have a PR with for the workspace name issue here. We still need to address the email issue, maybe in another PR.

[mountiny]

Thanks for looking, the failure with email in memberData is weird as i did not encounter that when testing locally.

@rlinoz you need to comment out Guide assignment in your local VM as per testing instructions to get this working locally

I dont think this is a blocker, we knew about the unavailabile workspace showing and included it in a follow up issue for the flow (linked in the pr), since this is a new feature, i will remove the blocker label

[mountiny]

This is the follow up issue #31314

@rlinoz Thank you very much for working on this one 🙇 sorry for the trouble

[rlinoz]

@luacmartins since your PR was CP'd I think we can close this issue, what do you think?

[mountiny]

@rlinoz Can you confirm in staging the issue is fixed? then we can close since there are no payments

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Pass optimistic workspaceName as param #31861

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[rlinoz]

The option to pay with a business account is not showing up for me in 1-1 money requests anymore, I will check why later, but if any of you knows why 😄

[mountiny]

I get it locally

I think the issue must be with the currency of the report/ if you can use wallet and such, seems to work fine in main

[mountiny]

@rlinoz brought up that I have been looking at expense report which is correct and I am blind haha, this is not showing up for IOU reports unless they are in USD currency

[mountiny]

I made a PR but I still kinda think we can leave it as is, now the flow works fine for US based folks where the request is made in USD and the IOU report is in USD. The experience of the bottom up flow is not great at the moment as if you are out of US, then setting up global reimbursement is something which will take some time and needs to be done in OldDot. I think we can leave it as is for now cc @puneetlath

[puneetlath]

I agree. I think this is fine for now.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Pass optimistic workspaceName as param #31861

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[puneetlath]

No payments needed. Closing.