Deploy Checklist: New Expensify 2023-11-23

[github-actions]

Release Version: 1.4.3-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update Close-Account.md #29523
• Allow receipt recovery if the upload fails #29790
• [Form Provider Refactor] BankAccountManualStep #30525
• Create v1 Collect workspace Bottom Up flow #30582
• fix: fix lhn previews #31061
• Add Session check for TaskHeaderActionButton #31200
• Fix: emoji suggestion does't reopen on revisit #31289
• [No QA] Fix background refresh for Android #31326
• [TS Migration] Migrate Checkbox.js to TypeScript #31369
• [NO QA] [TS migration] Migrate 'RadioButtonWithLabel.js' component to TypeScript #31379
• Add error message for throttled ECard activation #31462
• Fix: Two tags are highlighted at the same time #31475
• [TS migration] Migrate 'Banner.js' component to TypeScript #31496
• long-workspace-name-fix #31516
• [TS Migration] Migrate UnreadActionIndicator.js to TypeScript #31528
• [NoQA] add global config for timeouts #31549
• [No QA] Cross-check the files touched by a PR in typecheck #31599
• iOS - Task - Scroll bar in the task confirmation page is on the left #31608
• Fix 29806: code paste bug on private note #31619
• Invalid red dot briefly appears by closing 'room' tab when there's no prior action #31669
• [ImgBot] Optimize images #31700
• fix: 31688 Notification preferences page appears again after refreshing the page #31702
• [perf] Migrate LHNOptionList to FlashList #31711
• Remove all unused mock betas #31783
• refactor ref forwarding in CheckboxWithLabel #31801
• [CP Stag] Navigate user to BBA flow #31804
• [CP Staging] fix: add missing default value #31817
• [CP Staging] Only show the VBBA payment option for expense reports #31841
• [CP Stag] Revert "Fix 29806: code paste bug on private note" #31852
• Revert "fix: fix lhn previews" #31860
• [CP Stag] Pass optimistic workspaceName as param #31861
• [CP Staging] Fix regression in workspace name #31880
• [CP Staging] Show Business Bank account as payment option on expense reports #31908
• [CP Staging] revert optimistic receipt errors #31911
• [CP Staging] Update fastlane to latest #31914

Deploy Blockers:

• [HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users #31792
• [WAITING ON CHECKLIST] [$500] Bank account - App crashes when tapping on Fix the errors in Connect BA page #31795
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account #31797
• [HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803
• Chat - “Paste and Match Style”, “Paste as plain text”, Shift+Option+Cmd+V doesn't remove markdown #31805
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace #31814
• [$500] [HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown #31829
• [HOLD for payment 2023-12-07] [$500] Bank account - Error still shows up after checking the ToS checkbox in account selection page #31830
• The app crashed when an employee requested money for the second time from the admin #31833
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Distance - Wrong error message is shown when creating an invalid distance request #31834
• [HOLD for payment 2024-02-07] [$500] Chat - "Hmm..page isn't here" briefly displayed after select business account #31836
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Expense - Bank account option is absent in Pay with Expensify dropdown #31837
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] IOU - LHN for IOU report shows the local currency when a different currency is requested #31838
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Chat - After finishing the bank account closure process, the system shows a message indicating 'Unavailable Workspace and undefined in LHN #31839
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] IOU - IOU report preview in LHN does not show the latest amount when the amount is updated #31840
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid #31844
• [$500] Bank Account - Beneficial owner form isn't displayed after filling it, exit the BA set up and return #31848
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Workspace - Workspace name misalignment below room name #31867
• Workspace name under the room name is not center aligned #31871
• [$500] Bank Account - Navigation Problem in "Get assistance" page after a reload #31892
• Web - Task - Checkmark is not automatically updated when assignee is not set #31909
• Re-testing PR #31917

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[melvin-bot]

📣 @github-actions[bot]! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[os-botify]

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.3-0 🚀

[luacmartins]

Checking off #31792. Repro in prod

[kavimuru]

Regression is at 47% progress.
We need exact reproduction steps for #29790 (comment)

[luacmartins]

Checking off #31795. We CPed a fix

[luacmartins]

Checking off #31797. We CPed a fix.

[kavimuru]

Regression is less than 1% left. We are validating couple PRs.
#26790 blocked with #31811

[Julesssss]

Checking off #31830 as it wasn't confirmed yet in production...

[kavimuru]

Regression completed. Validating the last cp
#31061 failing with #31844
#30582 failing with #31829, #31833, #31836 and #31839

[luacmartins]

Checking off #31805. We reverted the offending PR.

[luacmartins]

Checking off #31829. We CPed a fix.

[luacmartins]

• 31834 - we have a revert PR in place
• 31854 - needs investigation. Came from this PR
• 31837 - PR with fix here. Came from 30582
• 31839 - needs investigation. Came from 30582
• 31848 - needs investigation

Unfortunately reverting #30582 is not straightforward since there are many conflicts already

[luacmartins]

Checking off PRs below. We reverted the offending PR:

• [HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] IOU - LHN for IOU report shows the local currency when a different currency is requested #31838
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] IOU - IOU report preview in LHN does not show the latest amount when the amount is updated #31840
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid #31844

[luacmartins]

Checking off #31833. Resolved.

[luacmartins]

Checking off #31836. Demoted to NAB.

[luacmartins]

Ok, final update for the next deployer:

#31834 - we have a revert PR #31854 in place
#31837 - we have a fix PR #31858
#31839 - we have a fix PR #31861, but there's another issue that I found while testing that still needs to be addressed
#31848 - I did not have time to investigate this one

[mountiny]

Checking #31892 demoting

[mountiny]

Demoted #31848

[dangrous]

I can replicate #31909 on production, I'm just asking QA to confirm and then I will demote it from a deploy blocker

[mountiny]

Demoted the last blocker #31909

[luacmartins]

Checking off #29790. We merged and CPed a partial revert.
Checking off #30582. We addressed all blockers coming from that PR and the feature is still a WIP.

[AndrewGable]