Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Auth CreateFund returned an error appears when adding debit card #32126

Closed
3 of 6 tasks
kbecciv opened this issue Nov 28, 2023 · 42 comments
Closed
3 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.4.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31133

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any Expensifail account
  3. Go to Settings -> Wallet -> Add bank account -> Debit card
  4. Fill form with correct data
  5. Save the card data

Expected Result:

The debit card is added without any errors

Actual Result:

Auth CreateFund returned an error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (29)

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Nov 28, 2023

Error in production

image (30)

@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 28, 2023
@AndrewGable
Copy link
Contributor

Removing deploy blocker label as it's happening in production.

@melvin-bot melvin-bot bot added the Overdue label Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

@srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 5, 2023

@srikarparsi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@srikarparsi
Copy link
Contributor

looked into the code, believe it's an error with stripe because of the status code, will make more progress tomorrow.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 6, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@srikarparsi Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 13, 2023

@srikarparsi Still overdue 6 days?! Let's take care of this!

@srikarparsi
Copy link
Contributor

Had finals last week and this week but just finished them up. I'm OOO on Friday for graduation but will add this to my list of things to investigate tomorrow and will leave an update.

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@srikarparsi Eep! 4 days overdue now. Issues have feelings too...

@srikarparsi
Copy link
Contributor

Still looking into this, it's a Stripe error but I'm not able to find what changes could be causing this. I'll probably ask for help if I can't find an explanation tomorrow.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@srikarparsi Eep! 4 days overdue now. Issues have feelings too...

@srikarparsi
Copy link
Contributor

Working limited hours because of Christmas/New Year, will leave an update towards the beginning of next week

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@marcochavezf
Copy link
Contributor

Oh sorry to the missing ping. Yeah, we should ask them for a new token if it's expired. There should a GH created automatically every 3 months I think to request a new token. Let me find it

@marcochavezf
Copy link
Contributor

These are the issues to request a new token https://github.com/Expensify/Expensify/issues?q=is%3Aissue+%22Rotate+Bancorp+RFT+API+Sandbox+token%22+, and this is the last one https://github.com/Expensify/Expensify/issues/296548. Could you look for the expiry date? The last time it was working was on Dec 21, 2023 but it probably already expired

@srikarparsi
Copy link
Contributor

Got it, so I believe the next issue will be created on February 28th. So would next steps since the token already expired be to create one of these issues, assign it to myself, and rotate the token?

@srikarparsi srikarparsi added Weekly KSv2 and removed Daily KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2024
@srikarparsi
Copy link
Contributor

Hey @marcochavezf! Friendly bump on the above question :)

@melvin-bot melvin-bot bot removed the Overdue label Feb 27, 2024
@marcochavezf
Copy link
Contributor

Yup, if we confirmed that token is expired then it will be time to contact Bancorp for another token. IIRC in another GH issue, Bancorp mentioned that another company/contact will be in charge of rotating the token. I think @deetergp has more info about it

@deetergp
Copy link
Contributor

The next issue wasn't going to run until May, but it looks like we need it to run sooner. I retried the job and it generated the issue and assigned it to @francoisl here. Outside of that, the only real information I have is that dealing with Bancorp/Tabapay is a bit like pulling teeth. They are slow to respond and need to be bumped daily till you get what you need from them. 😬

@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2024
@srikarparsi
Copy link
Contributor

Still seems to be failing. Logs here. The isDebitCard check is failing which means the Bancorp response doesn't have the "card" property. The Bancorp token seems to be rotated above but I'll check more on this tomorrow, maybe the response format might've changed for testing cards?

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

This issue has not been updated in over 15 days. @srikarparsi eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@srikarparsi
Copy link
Contributor

No update still

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@srikarparsi
Copy link
Contributor

srikarparsi commented Jun 17, 2024

This is no longer reproducible with this debit test card. Closing this out

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@izarutskaya
Copy link

Issue is still reproducible
Build 9.0.3-1

Bug6526959_1719545907138.Desktop-Wallet-Debit-card-can-not-added.mp4

@izarutskaya izarutskaya reopened this Jun 28, 2024
@srikarparsi
Copy link
Contributor

Hey, do you think you could try again with this card number: 4000056655665556. It's still working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants