Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-11-27 #32066

Closed
53 tasks done
github-actions bot opened this issue Nov 27, 2023 · 16 comments
Closed
53 tasks done

Deploy Checklist: New Expensify 2023-11-27 #32066

github-actions bot opened this issue Nov 27, 2023 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Release Version: 1.4.4-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

This comment was marked as off-topic.

@os-botify

This comment was marked as off-topic.

@os-botify os-botify bot reopened this Nov 27, 2023

This comment was marked as off-topic.

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 27, 2023
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.4-0 🚀

@kavimuru
Copy link

kavimuru commented Nov 28, 2023

Regression is 2% left.
#31050 failing with #32082
#31102 failing with #32076
#31401 failing with #32104 and #32085
#31133 failing with #32126
#31291 failing with #32078 and #32122
#31629 failing with #32079
#31353 not sure if we have to test the internal steps provided, #31353 (comment)

@mountiny
Copy link
Contributor

Demoted #32118

@mountiny
Copy link
Contributor

Demoted #32080 repro in production

@Julesssss
Copy link
Contributor

Demoting #32119. It isn't reproducable in prod so its impossible to confirm.

It's still a high-priority issue.

@Julesssss
Copy link
Contributor

The comment wasn't added, but I cherry-picked the fix to issue #31830

@luacmartins
Copy link
Contributor

Checking off #32083 and #32104. We CPed a revert and tested well in staging.

@luacmartins
Copy link
Contributor

Checking off #32077. We CPed a fix and it tests well in staging.

@marcaaron
Copy link
Contributor

Checking off #32082 - seems like tester error

@mvtglobally
Copy link

mvtglobally commented Nov 28, 2023

Regression is completed.

No Open blockers

#31050 failing with #32082
#31102 failing with #32076. Repro in PROD, checking off
#31133 failing with #32126
#31291 failing with #32078(repro in prod) and #32122(closed as not an issue) checking off.
#31353 can you QA internally?
#31401 failing with #32104 and #32085. Both are closed now. Do we need to retest or can check it off?
#31629 failing with #32079. Repro in prod, checking off.
#31851 just pending IOS validation
#32097 (comment) - Can you QA internally?

@AndrewGable
Copy link
Contributor

@luacmartins tested #32097, checking it off.

@mountiny
Copy link
Contributor

Checking #31353 off, QA almost finished, but not a blocker

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants