Web - Profile - When selecting the last country or state extra space is displayed for a while #31737

ZhenjaHorbach · 2023-11-22T19:03:18Z

Details

Web - Profile - When selecting the last country or state extra space is displayed for a while

Fixed Issues

$ #31660
PROPOSAL: #31660 (comment)

Tests

Go to Settings > Profile > Personal details > Address.
Click on the country and select "Zimbabwe."
Click on the country again and don't notice space below.
Now, select "United States" and choose the last state.
Click on the state again and don't notice extra space for a while

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Personal details > Address.
Click on the country and select "Zimbabwe."
Click on the country again and don't notice space below.
Now, select "United States" and choose the last state.
Click on the state again and don't notice extra space for a while

QA Steps

Go to Settings > Profile > Personal details > Address.
Click on the country and select "Zimbabwe."
Click on the country again and don't notice space below.
Now, select "United States" and choose the last state.
Click on the state again and don't notice extra space for a while

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-22.at.19.53.58.mov

Android: mWeb Chrome

web-android.mov

iOS: Native

Screen.Recording.2023-11-22.at.19.49.50.mov

iOS: mWeb Safari

web-ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

… extra space is displayed for a while

melvin-bot · 2023-11-22T19:03:22Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-11-22T19:03:24Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-11-22T21:05:42Z

@burczu
Hello )
PR is ready

Plus a little explanation

Before the last comment I implemented the pre-negotiated solution
Which works great on web and desktop

But I noticed a small flaw on mobile apps
The fact that during opening we can see a screen with the first elements
And then immediately go to the last one

(Video without opacity while transitioning between screens)

2.mov

It looks much better than main
But it still looks like a bug

(Main)

Screen.Recording.2023-11-22.at.21.59.18.mov

Therefore, I decided to update the solution a little and added the last comment where I hide the elements until we have the desired index. And when the elements are visible we will be in the right place

(Video with opacity while transitioning between screens)

3.mov

Should I reconsider my last comment?

burczu · 2023-11-27T07:52:30Z

src/components/SelectionList/BaseSelectionList.js

@@ -71,6 +72,8 @@ function BaseSelectionList({
    const shouldShowSelectAll = Boolean(onSelectAll);
    const activeElement = useActiveElement();
    const isFocused = useIsFocused();
+    const [maxToRenderPerBatch, setMaxToRenderPerBatch] = useState(shouldUseDynamicMaxToRenderPerBatch ? 0 : 5);


I think we could extract this 5 to some constant with meaningful name.

burczu · 2023-11-27T07:53:38Z

src/components/SelectionList/BaseSelectionList.js

+                const listHeight = lodashGet(nativeEvent, 'layout.height', 0);
+                const itemHeight = lodashGet(nativeEvent, 'layout.y', 0);
+
+                setMaxToRenderPerBatch((Math.ceil(listHeight / itemHeight) || 0) + 5);


Is this 5 here the same as the one I've mentioned in my previous comment? If so the constant has even more sense I think.

ZhenjaHorbach · 2023-11-27T10:00:53Z

@burczu
Done )

burczu · 2023-11-27T10:36:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-27.at.12.28.11.mov

Android: mWeb Chrome

Screen.Recording.2023-11-27.at.12.31.01.mov

iOS: Native

Screen.Recording.2023-11-27.at.12.26.20.mov

iOS: mWeb Safari

Screen.Recording.2023-11-27.at.12.29.31.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-27.at.12.32.01.mov

MacOS: Desktop

Screen.Recording.2023-11-27.at.12.33.49.mov

burczu

LGTM

mountiny

Seems good to me, thank you both @ZhenjaHorbach and @burczu 🚀

OSBotify · 2023-11-27T14:41:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-27T19:23:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-29T11:46:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.4-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with Web - Profile - When selecting the last country or state…

6c876c4

… extra space is displayed for a while

ZhenjaHorbach requested a review from a team as a code owner November 22, 2023 19:03

melvin-bot bot removed the request for review from a team November 22, 2023 19:03

melvin-bot bot requested a review from burczu November 22, 2023 19:03

ZhenjaHorbach added 3 commits November 22, 2023 20:10

Update value to increase

a175205

Fix lint warning

2b22aa7

Fix bug with mobile

2749bfd

Optimize the list while transitioning between screens

5e1acdc

burczu reviewed Nov 27, 2023

View reviewed changes

ZhenjaHorbach added 2 commits November 27, 2023 10:56

Add constants for maxToRenderPerBatch

6cf91f6

Fix conflicts

31b15b1

burczu approved these changes Nov 27, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny November 27, 2023 11:35

mountiny assigned ZhenjaHorbach Nov 27, 2023

mountiny approved these changes Nov 27, 2023

View reviewed changes

mountiny merged commit 090dc3a into Expensify:main Nov 27, 2023
16 checks passed

github-actions bot mentioned this pull request Nov 27, 2023

Deploy Checklist: New Expensify 2023-11-27 #32066

Closed

53 tasks

melvin-bot bot mentioned this pull request Nov 29, 2023

[HOLD for payment 2023-12-06] [$500] Web - Profile - When selecting the last country or state extra space is displayed for a while #31660

Closed

6 tasks

burczu mentioned this pull request Dec 11, 2023

Selection List refactor phase 3: base #27767

Merged

67 tasks

sobitneupane mentioned this pull request Feb 1, 2024

[HOLD for payment 2024-03-06] [$500] Date of birth - Lower portion of year in the list only appears after some delay #34763

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web - Profile - When selecting the last country or state extra space is displayed for a while #31737

Web - Profile - When selecting the last country or state extra space is displayed for a while #31737

ZhenjaHorbach commented Nov 22, 2023 •

edited

Loading

melvin-bot bot commented Nov 22, 2023

melvin-bot bot commented Nov 22, 2023

ZhenjaHorbach commented Nov 22, 2023 •

edited

Loading

burczu Nov 27, 2023

burczu Nov 27, 2023

ZhenjaHorbach commented Nov 27, 2023

burczu commented Nov 27, 2023 •

edited

Loading

burczu left a comment

mountiny left a comment

OSBotify commented Nov 27, 2023

OSBotify commented Nov 27, 2023

OSBotify commented Nov 29, 2023

Web - Profile - When selecting the last country or state extra space is displayed for a while #31737

Web - Profile - When selecting the last country or state extra space is displayed for a while #31737

Conversation

ZhenjaHorbach commented Nov 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 22, 2023

melvin-bot bot commented Nov 22, 2023

ZhenjaHorbach commented Nov 22, 2023 • edited Loading

burczu Nov 27, 2023

Choose a reason for hiding this comment

burczu Nov 27, 2023

Choose a reason for hiding this comment

ZhenjaHorbach commented Nov 27, 2023

burczu commented Nov 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 27, 2023

OSBotify commented Nov 27, 2023

OSBotify commented Nov 29, 2023

ZhenjaHorbach commented Nov 22, 2023 •

edited

Loading

ZhenjaHorbach commented Nov 22, 2023 •

edited

Loading

burczu commented Nov 27, 2023 •

edited

Loading