[Wave 6: Workspace Chats] Expense - Report header shows 'owes' instead of 'paid' after submitting the expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32157

Action Performed:

Precondition:

• User is an employee of a Collect workspace

1. Log in to ND as the employee
2. Go to the workspace chat > + > Request money
3. Create a manual request
4. Click on the expense preview
5. Click Submit
6. Take note of the content on the header
7. Click on the header subtitle to return to workspace main chat
8. Click on the expense preview

Expected Result:

In Step 6, the header should show 'owes'

Actual Result:

In Step 6, the header shows 'paid' after submitting the expense.
It becomes 'owes' after the report is revisited in Step 8

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296225_1701362647382.20231130_231317.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010068d3d052c3afed
• Upwork Job ID: 1730282956105023488
• Last Price Increase: 2023-11-30
• Automatic offers:
• s77rt | Reviewer | 27910611
• cubuspl42 | Contributor | 28065391

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010068d3d052c3afed

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[amyevans]

I think @mountiny fixed this recently but I don't have the PR link on hand to confirm

[mountiny]

I have only fixed this for draft report but did not know this turns to paid after submission so one more thing to fix, added to the wave6 project. I will remove the Help Wanted label and we can handle it internally

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[rezkiy37]

@mountiny, I was trying to reproduce the bug, but looks like I found one more. I don't understand why the app archives a chat, once I submit a money request.

Archives.a.room.mp4

[mountiny]

This will be because of the Submit & Close settings for the policy so after submitting the report is considered closed

[rezkiy37]

@mountiny, so, after investigation, I've found a field of a report that takes responsibility for this behaviour. It is hasOutstandingIOU. When the app submits a report optimistically, it passes hasOutstandingIOU as false, but the backend always returns true.

Once, I added hasOutstandingIOU: true, explicitly, everything works smoothly. Unfortunately, I am not familiar with the value yet. Could you please explain me whether it can be used in this way or not?

Change.value.to.true.mp4

[rezkiy37]

Melvin, no overdue here. Waiting for answer on a comment.

[mountiny]

@rezkiy37 I see I think it makes sense, in general I think this field is just more confusing now as we are moving hte GBR to the parent chat with the hasOutstandingChildRequest key.

Could you raise a PR with this change please?

[rezkiy37]

Preparing a PR - #32436.

[mountiny]

I think we can deprecate this prop, discussing internally yet to make sure I have not missed anything

[rezkiy37]

This issue is gonna be fixed in a scope of #32565.

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

$500 for a review to @cubuspl42

[slafortune]

Paid!