Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-15] Stub for Expensify/Expensify/issues/329101 / Auto-switch to #focus mode App changes #32372

Closed
marcaaron opened this issue Dec 1, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Dec 1, 2023

See https://github.com/Expensify/Expensify/issues/329101

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b91e885c3489a3ea
  • Upwork Job ID: 1730673965042880512
  • Last Price Increase: 2023-12-01
@marcaaron marcaaron added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b91e885c3489a3ea

Copy link

melvin-bot bot commented Dec 1, 2023

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 4, 2023

@hoangzinh, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcaaron
Copy link
Contributor Author

Assigning a BZ to help with payment eventually.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. Overdue labels Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 Reviewing Has a PR in review Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 Weekly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title Stub for Expensify/Expensify/issues/329101 / Auto-switch to #focus mode App changes [HOLD for payment 2023-12-15] Stub for Expensify/Expensify/issues/329101 / Auto-switch to #focus mode App changes Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 8, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 14, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

Issue is ready for payment but no BZ is assigned. @miljakljajic you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Dec 15, 2023

### Payment Summary
[Upwork Job](https://www.upwork.com/jobs/~01b91e885c3489a3ea)
- <Role>: @hoangzinh paid $(<amount>) via Upwork (<Replace with offer link>)

#### BugZero Checklist (@miljakljajic)
- [ ] I have verified the correct assignees and roles are listed above
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1730673965042880512/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct

@miljakljajic
Copy link
Contributor

Weird - @laurenreidexpensify is already assigned, is this a Melvin bug?

@miljakljajic
Copy link
Contributor

Sent you a contract @hoangzinh - accept it and I'll get you paid right away!

@hoangzinh
Copy link
Contributor

Accepted. Thanks @miljakljajic

@miljakljajic
Copy link
Contributor

Lovely, paid! Thank you for your work.

Do we need regression test steps for this one @marcaaron or are we good?

@marcaaron
Copy link
Contributor Author

Yeah! Probably a good idea. I haven't added any to test rail yet.

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@laurenreidexpensify laurenreidexpensify removed their assignment Dec 18, 2023
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 18, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants