Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update users to focus mode automatically if they have the minimum report number #30664

Merged
merged 41 commits into from
Dec 5, 2023

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 31, 2023

Details

Front end changes required to auto-switch a user over to focus mode when they exceed a certain number of reports.

This PR must be tested together with:

Auth PR: https://github.com/Expensify/Auth/pull/9085
Web-PR: https://github.com/Expensify/Web-Expensify/pull/39450

Fixed Issues

https://github.com/Expensify/Expensify/issues/329101

$ #32372

Tests

  1. Sign into an account that has less than 30 chats total (brand new one ideally)
  2. Verify that no modal is shown to user
  3. Verify a log is in the JS console that looks like this:
[info] Not switching user to optimized focus mode as they do not have enough reports - {"reportCount":2}
  1. Sign into an account that has more than 30 chats total that is currently in focus mode.
  2. Verify that no modal is shown to user
  3. Sign into an account that has more than 30 chats total that is not currently in focus mode.
  4. Verify that a modal is presented that tells you that you have been switched to focus mode.
  5. Press the "Got it" button and verify the modal is dismissed
  6. Reload the page
  7. Verify that no modals appear
  8. Sign out and sign in again
  9. Verify the modal does not appear again
  10. Sign into an account that has more than 30 chats total that is not currently in focus mode and has not yet seen the modal.
  11. Verify that a modal is presented that tells you that you have been switched to focus mode.
  12. Tap the "here" link and verify the modal closes and you are brought to the preference page where you can switch back if you want.

Dev only test to simulate signed in users getting new app version

  • switch to main and sign in with an account that has not switched to focus mode yet and is still in "Most recent" mode

  • switch to this branch and refresh

  • verify the modal appear

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native 2023-11-01_19-02-30
Android: mWeb Chrome 2023-11-01_18-54-05
iOS: Native

2023-11-01_13-48-20

iOS: mWeb Safari

2023-11-01_14-18-54

MacOS: Chrome / Safari

2023-11-01_13-24-08

MacOS: Desktop

2023-11-01_13-26-56

@marcaaron marcaaron changed the title [WIP] Update users to focus mode [HOLD] Update users to focus mode automatically if they have the minimum report number Nov 1, 2023
@marcaaron marcaaron self-assigned this Nov 1, 2023
src/libs/actions/App.js Outdated Show resolved Hide resolved
Copy link

melvin-bot bot commented Dec 1, 2023

@fedirjh @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcaaron marcaaron requested a review from a team December 1, 2023 19:40
@melvin-bot melvin-bot bot requested review from c3024 and removed request for a team December 1, 2023 19:40
Copy link

melvin-bot bot commented Dec 1, 2023

@c3024 @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcaaron marcaaron requested review from a team and removed request for fedirjh and c3024 December 1, 2023 19:41
@melvin-bot melvin-bot bot removed the request for review from a team December 1, 2023 19:43
Copy link

melvin-bot bot commented Dec 1, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcaaron marcaaron requested a review from a team December 1, 2023 19:44
@melvin-bot melvin-bot bot removed the request for review from a team December 1, 2023 19:44
Copy link

melvin-bot bot commented Dec 1, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@hoangzinh hoangzinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested well!

@melvin-bot melvin-bot bot requested a review from bondydaa December 1, 2023 20:18
Copy link

melvin-bot bot commented Dec 1, 2023

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@bondydaa bondydaa merged commit 395dea4 into main Dec 5, 2023
22 checks passed
@bondydaa bondydaa deleted the marcaaron-setLastOfferedFocusMode branch December 5, 2023 16:30
@@ -109,7 +62,7 @@ function AnchorRenderer(props) {
key={props.key}
displayName={displayName}
// Only pass the press handler for internal links. For public links or whitelisted internal links fallback to default link handling
onPress={internalNewExpensifyPath || internalExpensifyPath ? navigateToLink : undefined}
onPress={internalNewExpensifyPath || internalExpensifyPath ? Link.openLink : undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App crashes when open internal link. Link.openLink requires 3 params as above.
Here's PR fixing this - #32553

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2023

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2023

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2023

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants