-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update users to focus mode automatically if they have the minimum report number #30664
Conversation
…t into a different PR
…e() to happen forever
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested well!
@@ -109,7 +62,7 @@ function AnchorRenderer(props) { | |||
key={props.key} | |||
displayName={displayName} | |||
// Only pass the press handler for internal links. For public links or whitelisted internal links fallback to default link handling | |||
onPress={internalNewExpensifyPath || internalExpensifyPath ? navigateToLink : undefined} | |||
onPress={internalNewExpensifyPath || internalExpensifyPath ? Link.openLink : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App crashes when open internal link. Link.openLink
requires 3 params as above.
Here's PR fixing this - #32553
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
Details
Front end changes required to auto-switch a user over to focus mode when they exceed a certain number of reports.
This PR must be tested together with:
Auth PR: https://github.com/Expensify/Auth/pull/9085
Web-PR: https://github.com/Expensify/Web-Expensify/pull/39450
Fixed Issues
https://github.com/Expensify/Expensify/issues/329101
$ #32372
Tests
Dev only test to simulate signed in users getting new app version
switch to main and sign in with an account that has not switched to focus mode yet and is still in "Most recent" mode
switch to this branch and refresh
verify the modal appear
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop