-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate '[Components Group 1]' component to TypeScript #36764
[TS migration] Migrate '[Components Group 1]' component to TypeScript #36764
Conversation
Please add the missing screenshots/videos |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movweb.2.mp4 |
Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
@rayane-djouah Please tag me once the screenshots / videos are added |
@rayane-djouah Any update here? |
Working on testing and recordings today |
@s77rt screenshots / videos are added |
Updated |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #36273 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Conflicts however
@AndrewGable I resolved the conflicts, could you please review? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.47-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀
|
Details
Fixed Issues
$ #36273
$ #36125
$ #36126
$ #36127
$ #36128
PROPOSAL: N/A
Tests
For
SAMLLoadingIndicator
(from #29526):For
FocusModeNotification
(from #30664):For
ShowMoreButton
:For
TaxPicker
(From #32550):Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.1.Recording.2024-02-25.221221.mp4
android.3.Recording.2024-02-25.221450.mp4
Android: mWeb Chrome
mweb.chrome.1.webm
mweb.chrome.3.Recording.2024-02-25.203701.mp4
iOS: Native
ios.3.Recording.2024-02-25.232823.mp4
iOS: mWeb Safari
mweb.safari.1.Recording.2024-02-25.223550.mp4
mweb.safari.3.Recording.2024-02-25.230042.mp4
MacOS: Chrome / Safari
web.1.Recording.2024-02-25.202254.mp4
web.3.Recording.2024-02-25.202622.mp4
MacOS: Desktop
desktop.1.Recording.2024-02-25.205114.mp4
desktop.3.Recording.2024-02-25.205422.mp4