Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [TS migration] Migrate 'SAMLLoadingIndicator.js' component to TypeScript #36125

Closed
melvin-bot bot opened this issue Feb 8, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Feb 8, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/SAMLLoadingIndicator.js 9
@ghost
Copy link

ghost commented Feb 8, 2024

I want to work on it

@allgandalf
Copy link
Contributor

dibs

Copy link
Author

melvin-bot bot commented Mar 2, 2024

@slafortune
Copy link
Contributor

Reassigning a BZ - @CortneyOfstad is OOO until 3/11

@slafortune slafortune added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Mar 4, 2024
Copy link
Author

melvin-bot bot commented Mar 4, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SAMLLoadingIndicator.js' component to TypeScript [HOLD for payment 2024-03-13] [TS migration] Migrate 'SAMLLoadingIndicator.js' component to TypeScript Mar 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2024
Copy link
Author

melvin-bot bot commented Mar 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

Copy link
Author

melvin-bot bot commented Mar 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@AndrewGable] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@MitchExpensify
Copy link
Contributor

No regression steps needed as this is a TS migration issue

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2024
Copy link
Author

melvin-bot bot commented Mar 13, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@rayane-djouah
Copy link
Contributor

Payment will be handled here: #36273, we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants