[$500] Chat - No gradient between the solid color and the image in the background

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Open any new chat.

Expected Result:

There is color gradient between the solid color and the image in the background.

Actual Result:

There is no gradient between the solid color and the image in the background.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d44d0270ef23b10b
• Upwork Job ID: 1731743109124833280
• Last Price Increase: 2023-12-04

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d44d0270ef23b10b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[StefanNemeth]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no gradient between the solid color and the image in the background

What is the root cause of that problem?

imgbot made an optimization to the background images which caused the colour gradient on them to break. This was already fixed in a previous PR by ignoring the file: #30512

However, due to changing the file names (by introducing a dark and light version of the background) in 5a5be5e the image was optimized by imgbot again before the files were updated in .imgbotconfig: 0feb155

What changes do you think we should make in order to solve the problem?

Reverting the automated optimization of ImgBot (67c42cb) should do the trick. Afterwards the background images won't be re-optimized due to the updated .imgbotconfig

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no gradient between the solid color and the image in the background.

What is the root cause of that problem?

We ignored the new background images here but didn't restore the original background image before optimized by ImgBot. So the background image remains optimized by image bot which causes this gradient issue.

What changes do you think we should make in order to solve the problem?

1. Restore the original background image before optimized by ImgBot, they can be found in this PR
2. It's still a very dangerous situation to be in, this issue initially was caused by us renaming the background image without updating the ignoreFiles of ImgBot here. This can easily happen in the future as well so I'd like to make a suggestion to avoid this.

We can add a simple ESLint or check in GH workflow to detect ImgBot (and others if applicable)' ignoreFiles pattern that no longer matches any file and throw an error in the GH actions check. To resolve it the PR author must either:

• Add the file back that matches the ignoreFiles pattern
• Remove the ignoreFiles pattern if it's obsolete.

So similar issues to this would've been caught in the GH check before getting merged.

What alternative solutions did you explore? (Optional)

NA

[zanyrenney]

I am not convinced this is a bug. it looks like either the expected behaviour or extreme UI polish: